New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2361: remove and replace Bootstrap close styles and consolidate close button code #9531
CONSOLE-2361: remove and replace Bootstrap close styles and consolidate close button code #9531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
/assign @yapei
for QE approval
/lgtm cancel |
This PR has no user visible changes, and we have general docs and px approval for this epic. @ahardin-rh @sferich888 FYI /label docs-approved |
Unit tests fixed. Please retag, @spadgett |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
/hold cancel |
I went down a bit of a rabbit hole with this one, but I think it's good code cleanup/consolidation.
Two commits as the first is the removal and replacement and the second is to update the remaining close buttons to use a single component.