Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1983220: Fix pod terminal second scrollbar when user reduce the window size #9534

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Bug 1983220: Fix pod terminal second scrollbar when user reduce the window size #9534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/public/components/terminal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ class Terminal_ extends React.Component {
this.fitAddon.fit();
// update the pty
this.props.onResize(terminal.rows, terminal.cols);
// The internal xterm textarea was not repositioned when the window was resized.
// This workaround triggers a textarea position update to fix this.
// See https://bugzilla.redhat.com/show_bug.cgi?id=1983220
// and https://github.com/xtermjs/xterm.js/issues/3390
terminal._core?._syncTextArea?.();
});
}

Expand Down