Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2276: Add relevant alerts to node and project overviews #9535

Merged
merged 1 commit into from Aug 4, 2021

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Jul 16, 2021

Addresses: https://issues.redhat.com/browse/CONSOLE-2276

Add filtered alerts to node and project overviews based off the labels node= and namespace= using the existing alert component.

Cluster dashboard with all alerts:
Screen Shot 2021-07-16 at 5 11 04 PM

openshift-cluster-version project dashboard with filtered alerts:
Screen Shot 2021-07-16 at 5 11 26 PM

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard labels Jul 16, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcaianirh

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please squash

/assign @yapei @ahardin-rh @sferich888
for approvals

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2021
@jcaianirh
Copy link
Member Author

lgtm, please squash
@spadgett squashed thanks!

@ahardin-rh
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 23, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yapei
Copy link
Contributor

yapei commented Jul 26, 2021

@XiyunZhao will test the PR and report test results back

@XiyunZhao
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 29, 2021
@spadgett
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2021
@XiyunZhao
Copy link

This PR has been verified on the private build. Verifying is focus on the below two-point, let me know if you have any suggestion

  1. Label is added for the alerts. User is able to identify the alert easily on Node, Project overview page
  2. Layout and view of the alert on the status part

@sferich888
Copy link

What controls are we giving a user to 'filter' the alerts? Is that done on the same screen or in a different screen? What does the full UX of this look like?

@jcaianirh
Copy link
Member Author

@sferich888 the full ux is linked in the story, however, there's no interaction here for filtering. If the component is on the cluster dash there is no filter, if its on the project dash alerts are filtered by namespace= label, if on the node dash alerts are filtered by node= label

@RickJWagner
Copy link

Reviewed, discussed with PLM stakeholders. Approved.
/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 4, 2021
@openshift-ci openshift-ci bot merged commit bbf36b1 into openshift:master Aug 4, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants