New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2276: Add relevant alerts to node and project overviews #9535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcaianirh
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
Outdated
Show resolved
Hide resolved
02d6cc9
to
2871853
Compare
frontend/packages/console-app/src/components/nodes/node-dashboard/StatusCard.tsx
Outdated
Show resolved
Hide resolved
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please squash
/assign @yapei @ahardin-rh @sferich888
for approvals
176384d
to
4fca92c
Compare
|
/label docs-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@XiyunZhao will test the PR and report test results back |
/label qe-approved |
/hold cancel |
This PR has been verified on the private build. Verifying is focus on the below two-point, let me know if you have any suggestion
|
What controls are we giving a user to 'filter' the alerts? Is that done on the same screen or in a different screen? What does the full UX of this look like? |
@sferich888 the full ux is linked in the story, however, there's no interaction here for filtering. If the component is on the cluster dash there is no filter, if its on the project dash alerts are filtered by namespace= label, if on the node dash alerts are filtered by node= label |
Reviewed, discussed with PLM stakeholders. Approved. |
Addresses: https://issues.redhat.com/browse/CONSOLE-2276
Add filtered alerts to node and project overviews based off the labels node= and namespace= using the existing alert component.
Cluster dashboard with all alerts:
openshift-cluster-version project dashboard with filtered alerts: