Bug 1977936: OCS deployment using Multus: UI allows StorageCluster creation with empty public and cluster network in "Internal - Attached Devices" #9541
Conversation
openshift-ci
bot
added
the
bugzilla/severity-high
|
@SanjalKatiyar: This pull request references Bugzilla bug 1977936, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@SanjalKatiyar: This pull request references Bugzilla bug 1977936, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
LGTM |
|
/assign @bipuladh |
|
You need to fix this in a new storage system creation install wizard also |
as discussed with @afreen23 ; for 4.9 she will handle this in the new install flow PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| const hasConfiguredNetwork = | ||
| state.networkType === NetworkType.MULTUS | ||
| ? !!(state.publicNetwork || state.clusterNetwork) | ||
| : true; |
There was a problem hiding this comment.
Why are we not doing any check for cluster network ?
Returning true always for other option might cause problem too.
There was a problem hiding this comment.
We have no checks for Cluster Network. And for #9541 (review) we are doing this for attached-devices-mode.
|
@SanjalKatiyar: All pull requests linked via external trackers have merged: Bugzilla bug 1977936 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@SanjalKatiyar: new pull request created: #9566 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Disabled "Next" button if no network Interface (Public/Cluster) is selected for MULTUS.
