Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1980182: operator UI not working with multiple version CRD in 4.6 #9549

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented Jul 19, 2021

Cherry picks pull request #7305 (Bug 1888036) from @TheRealJon to the release-4.6 branch to resolve this issue. The cherry pick was not clean (some files did not exist back in 4.6), hence the difference in lines in the diff.

Tested locally using a 4.6 cluster and seems to do the trick. I modified an existing operators yaml and CRD to reproduce. See screenshots below.

https://bugzilla.redhat.com/show_bug.cgi?id=1980182

Setting up the 4.6 cluster

Screen Shot 2021-07-19 at 4 37 11 PM

Screen Shot 2021-07-19 at 4 39 16 PM

Reproduced issue

Screen Shot 2021-07-19 at 4 34 18 PM

With fix

Screen Shot 2021-07-19 at 4 40 52 PM

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@florkbr: This pull request references Bugzilla bug 1980182, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected Bugzilla bug 1980182 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1980182: operator UI not working with multiple version CRD in 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@florkbr florkbr requested a review from spadgett July 19, 2021 20:47
@openshift-ci openshift-ci bot added component/olm Related to OLM component/shared Related to console-shared labels Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

@florkbr: This pull request references Bugzilla bug 1980182, which is invalid:

  • expected the bug to target the "4.6.z" release, but it targets "---" instead
  • expected Bugzilla bug 1980182 to depend on a bug targeting a release in 4.7.0, 4.7.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1980182: operator UI not working with multiple version CRD in 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Cherry picks pull request openshift#7305 (Bug 1888036) from @TheRealJon to the
`release-4.6` branch to resolve this issue. Tested locally using a 4.6
cluster and seems to do the trick. I modified an existing operators yaml
and CRD to reproduce. See screenshots below.

https://bugzilla.redhat.com/show_bug.cgi?id=1980182
@florkbr florkbr force-pushed the bug-1980182-multi-crd-version-operator-ui branch from 4af3bdd to 1704185 Compare July 19, 2021 21:04
@spadgett
Copy link
Member

/bugzilla refresh
/assign @TheRealJon

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@spadgett: An error was encountered querying GitHub for users with public email (yapei@redhat.com) for bug 1980182 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh
/assign @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2021
@TheRealJon
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2021

@TheRealJon: This pull request references Bugzilla bug 1980182, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1888036 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1888036 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 20, 2021
@openshift-ci openshift-ci bot requested a review from yapei July 20, 2021 14:51
@florkbr
Copy link
Contributor Author

florkbr commented Jul 21, 2021

@TheRealJon @spadgett tide is saying we're missing labels... do we need to add those manually?

image

@TheRealJon
Copy link
Member

TheRealJon commented Jul 21, 2021

@florkbr No, the cherry-pick-approved label will be added by a group lead when they are ready for this to be merged, and the approved label will be added when one other owner approves this PR.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florkbr, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7bf977f into openshift:release-4.6 Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@florkbr: All pull requests linked via external trackers have merged:

Bugzilla bug 1980182 has been moved to the MODIFIED state.

In response to this:

Bug 1980182: operator UI not working with multiple version CRD in 4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants