Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): Allow only object storage deployment #9563

Merged
merged 1 commit into from Jul 22, 2021
Merged

(feat): Allow only object storage deployment #9563

merged 1 commit into from Jul 22, 2021

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented Jul 20, 2021 •
edited

Screenshot from 2021-07-21 16-33-58

Signed-off-by: Afreen Rahman afrahman@redhat.com

@openshift-ci openshift-ci bot requested review from bipuladh and shyRozen July 20, 2021 20:55
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 20, 2021
@afreen23 afreen23 force-pushed the mcg-only branch 2 times, most recently from d5fb834 to 12cc2c3 Compare July 21, 2021 11:10
@afreen23 afreen23 requested a review from vbnrh July 21, 2021 11:20
(feat): Allow only object storage deployment
5ed5b8a 
- added an advanced section which will allow support object storage deployment via MCG
- implements https://issues.redhat.com/browse/ODFE-95

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@afreen23 afreen23 requested a review from vbnrh July 21, 2021 11:51
vbnrh
vbnrh approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@vbnrh vbnrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good .

Just a suggestion to use a Switch for enabling MCG Only deployment than a checkbox. Will be more appropriate.

@vbnrh
Copy link
Contributor

vbnrh commented Jul 21, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@afreen23
Copy link
Contributor Author

Looks pretty good .

Just a suggestion to use a Switch for enabling MCG Only deployment than a checkbox. Will be more appropriate.

I will connect with UXD on that. Thanks for review @vbnrh

GowthamShanmugam
GowthamShanmugam reviewed Jul 21, 2021
View reviewed changes
.../create-storage-system/create-storage-system-steps/backing-storage-step/advanced-section.tsx
});
};
const handleExpanadableToggling: ExpandableSectionProps['onToggle'] = (isExpanded: boolean) => {
dispatch({ type: 'backingStorage/setIsAdvancedOpen', payload: isExpanded });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be !isExpanded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. This is PF expandable section, the handler passes isExpanded the state of expand - true/false .
If its expanded it will be true or false. We just leveraging this to set state of that in our wizard.
if its opened then it should be opened, even if the user navigates back and next.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@openshift-merge-robot openshift-merge-robot merged commit c01d2be into openshift:master Jul 22, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GowthamShanmugam GowthamShanmugam GowthamShanmugam left review comments

@vbnrh vbnrh vbnrh approved these changes

@bipuladh bipuladh Awaiting requested review from bipuladh

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@vbnrh vbnrh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@afreen23 @vbnrh @GowthamShanmugam @spadgett @openshift-merge-robot