Bug 1976939: Interacting with CatalogSource page #9570
Conversation
|
@dtaylor113: This pull request references Bugzilla bug 1976939, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-medium
dtaylor113
force-pushed
the
cypress-olm-remove-cust-catalog
branch
from
77d2b67
to
385125e
Compare
openshift-ci
bot
added
the
kind/cypress
|
@dtaylor113: This pull request references Bugzilla bug 1976939, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
@dtaylor113 I don't think this will address the problem as later checks like listing package manifests will fail if the catalog source isn't ready.
@spadgett, are you saying the 5 min. timeout isn't enough? UPDATE: Added the |
| @@ -7,7 +7,7 @@ declare global { | |||
| byLegacyTestID(selector: string): Chainable<Element>; | |||
| byButtonText(selector: string): Chainable<Element>; | |||
| byDataID(selector: string): Chainable<Element>; | |||
| byTestSelector(selector: string): Chainable<Element>; | |||
| byTestSelector(selector: string, options?: object): Chainable<Element>; | |||
There was a problem hiding this comment.
We should be using the same type def that Cypress uses for the options arg in cy.get
dtaylor113
force-pushed
the
cypress-olm-remove-cust-catalog
branch
from
385125e
to
e041b68
Compare
dtaylor113
force-pushed
the
cypress-olm-remove-cust-catalog
branch
from
e041b68
to
3d6715b
Compare
|
@dtaylor113 Sorry, I misread the description. I thought you had remove the status ready check. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@dtaylor113: All pull requests linked via external trackers have merged: Bugzilla bug 1976939 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR adds a 5 minute timeout for
Status==='READY'check inbeforeEach()for Admin -> Cluster Settings -> ConfigurationOperatorHub details page to ensure catalog source is READY before each test. This TC tests for several other detail page fields and values to verify the page; so checking for
Status === READYisn't neccesary for this particular test, but later tests edit the poll interval where we probably want the catalog source to beREADY.Also removed obsolete
/views/catalog-source.view.tshelper class which is no longer used since switching to Red Hat Operators for e2e testing. We are no longer retreiving Operators from a custom catalog source, so this helper class can be removed.