Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-6127: Fix missing build status translation in topology sidebar #9572

Merged
merged 1 commit into from Jul 22, 2021

Conversation

jerolimov
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-6127

Analysis / Root cause:
Generated strings in translation doesn't match expectation from Trans component.

Solution Description:
Remove the {link} and replace it with the component so that generated translation and code matches again.

Searched in our translation files for other cases (regex: [^{]\{[a-z]) and doesn't find any other case.

Screen shots / Gifs for design review:
Before:
broken-translation-before

After:
fixed-translation

Unit test coverage report:
Unchanged.

Test setup:

  1. Create a Deployment with a BuildConfig (via import from git for example)
  2. Open topology
  3. Select the Deployment and check the sidebar.
  4. The "Resources" tab contains a "Builds" section
  5. Switch to another language to see if the info Build #x was complete is translated correctly.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett July 21, 2021 16:43
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2021
@debsmita1
Copy link
Contributor

tested it for all the translations and can't see the missing i18n key errors anymore
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9c5df4e into openshift:master Jul 22, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants