Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1983091: Logic for getting default pull secret incorrect on project page #9593

Merged
merged 1 commit into from Jul 29, 2021
Merged

Bug 1983091: Logic for getting default pull secret incorrect on project page #9593

merged 1 commit into from Jul 29, 2021

Conversation

kdoberst
Copy link
Contributor

@kdoberst kdoberst commented Jul 22, 2021 •
edited

Address Bug 1983091

Adds all pull secrets listed in the default ServiceAccount in the project details page. Currently it only displays the first response form the API for a secret of type kubernetes.io/dockerconfigjson

If no imagePullSecrets are listed in the default ServiceAccount, then the "Not configured" link will be displayed allowing a user to create a pull secret in a modal. (This is current behavior)

Project detail
Screen Shot 2021-07-23 at 11 30 09 AM

Default ServiceAccount YAML
Screen Shot 2021-07-23 at 11 30 36 AM

Project detail when user doesn't have view secret permission
Screen Shot 2021-07-26 at 4 36 39 PM

Error if getting pull secret fails
Screen Shot 2021-07-26 at 2 45 55 PM

Video

Screen.Recording.2021-07-23.at.11.27.12.AM.mov

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jul 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@kdoberst: This pull request references Bugzilla bug 1983091, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1983091: Logic for getting default pull secret incorrect on project page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 22, 2021
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 22, 2021
spadgett
spadgett reviewed Jul 22, 2021
View reviewed changes
frontend/public/components/namespace.jsx Outdated Show resolved Hide resolved
frontend/public/components/namespace.jsx Outdated Show resolved Hide resolved
frontend/public/components/namespace.jsx Outdated Show resolved Hide resolved
@kdoberst kdoberst force-pushed the Bug-1983091-Logic-for-getting-default-pull-secret branch from c79cdfd to e9c6cee Compare July 23, 2021 18:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

@kdoberst: This pull request references Bugzilla bug 1983091, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1983091: Logic for getting default pull secret incorrect on project page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdoberst kdoberst force-pushed the Bug-1983091-Logic-for-getting-default-pull-secret branch from e9c6cee to f7eded1 Compare July 26, 2021 20:01
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@kdoberst
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@kdoberst: This pull request references Bugzilla bug 1983091, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1983091: Logic for getting default pull secret incorrect on project page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdoberst
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@kdoberst: This pull request references Bugzilla bug 1983091, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1983091: Logic for getting default pull secret incorrect on project page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdoberst
Copy link
Contributor Author

@spadgett Made requested changes. If they look good, please add lgtm label.

@kdoberst kdoberst force-pushed the Bug-1983091-Logic-for-getting-default-pull-secret branch from f7eded1 to 96de2dd Compare July 28, 2021 19:02
@kdoberst
Show all default pull secrets for a project.
0234858 
Show error if api call to get secrets fails.
@kdoberst kdoberst force-pushed the Bug-1983091-Logic-for-getting-default-pull-secret branch from 96de2dd to 0234858 Compare July 28, 2021 20:14
spadgett
spadgett approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kdoberst
Copy link
Contributor Author

/test frontend

@openshift-merge-robot openshift-merge-robot merged commit f9c5d9c into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@kdoberst: All pull requests linked via external trackers have merged:

Bugzilla bug 1983091 has been moved to the MODIFIED state.

In response to this:

Bug 1983091: Logic for getting default pull secret incorrect on project page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

@yapei yapei Awaiting requested review from yapei

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdoberst @spadgett @openshift-merge-robot