Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1985081: Fix Pipeline Download All #9596

Merged
merged 1 commit into from Aug 11, 2021
Merged

[release-4.8] Bug 1985081: Fix Pipeline Download All #9596

merged 1 commit into from Aug 11, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9533

/assign andrewballantyne

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 22, 2021
Merged
4 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@openshift-cherrypick-robot: Bugzilla bug 1985080 has been cloned as Bugzilla bug 1985081. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1985081: Fix Pipeline Download All

In response to this:

[release-4.8] Bug 1985080: Fix Pipeline Download All

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1985080: Fix Pipeline Download All [release-4.8] Bug 1985081: Fix Pipeline Download All Jul 22, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 22, 2021
@openshift-ci openshift-ci bot requested review from kyoto and zherman0 July 22, 2021 19:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1985081, which is invalid:

  • expected dependent Bugzilla bug 1985080 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1985081: Fix Pipeline Download All

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 22, 2021
@andrewballantyne
Copy link
Contributor

/assign @karthikjeeyar

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@jerolimov
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@jerolimov: This pull request references Bugzilla bug 1985081, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1985080 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1985080 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jerolimov
Copy link
Member

/assign

jerolimov
jerolimov approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it with a clusterbot instance and OpenShift Pipelines operator 1.1.2 (ocp-4.5 channel) because operator 1.5.0 (stable channel) doesn't work.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Contributor

because operator 1.5.0 (stable channel) doesn't work.

I believe that is expected, hence the ocp channel names. There has been shifts in compatibility as k8s has up-versioned. cc @karthikjeeyar

@jerolimov
Copy link
Member

because operator 1.5.0 (stable channel) doesn't work.

I believe that is expected, hence the ocp channel names. There has been shifts in compatibility as k8s has up-versioned. cc @karthikjeeyar

Yep, just wanted document that I used an "uncommon way" to verify this fix. Karthik provided some infos and another workaround for this in slack

@ecordell
Copy link
Contributor

ecordell commented Aug 4, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

1 similar comment
@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff for today, may make tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: skipping for now, may still be tagged today

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link
Contributor

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff this week

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@bparees bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 11, 2021
@openshift-ci openshift-ci bot merged commit 72491f0 into openshift:release-4.8 Aug 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1985081 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1985081: Fix Pipeline Download All

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne
Copy link
Contributor

/cherry-pick release-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 19, 2021
Merged
@openshift-cherrypick-robot
Copy link
Author

@andrewballantyne: new pull request created: #9839

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.8.z milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@jerolimov jerolimov

@andrewballantyne andrewballantyne

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.8.z
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@openshift-cherrypick-robot @andrewballantyne @jerolimov @ecordell @spadgett @bparees @karthikjeeyar