Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add flashsystem external storage #9602

Merged
merged 9 commits into from Jul 25, 2021
Merged

feature: add flashsystem external storage #9602

merged 9 commits into from Jul 25, 2021

Conversation

shdn-ibm
Copy link
Contributor

@shdn-ibm shdn-ibm commented Jul 23, 2021 •
edited

Add flashsystem as an exnternal storage to support ODF.
Snap of the page is shown as below
creation-page

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
@openshift-ci openshift-ci bot requested review from rawagner and shyRozen July 23, 2021 08:01
@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Jul 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

Hi @shdn-ibm. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2021
@afreen23
Copy link
Contributor

/assign

@afreen23
Copy link
Contributor

/ok=to-test

@shdn-ibm shdn-ibm marked this pull request as ready for review July 23, 2021 15:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2021
afreen23
afreen23 suggested changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. Please run yarn i18n under the /frontend dir.
This will create json for i18n

...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/models.ts Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
@afreen23
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 23, 2021
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jul 24, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021
afreen23
afreen23 suggested changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing due to lint errors
Please fix them.

...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
afreen23
afreen23 suggested changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits into a single commit

...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
afreen23
afreen23 suggested changes Jul 24, 2021
View reviewed changes
...storage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/type.ts Outdated Show resolved Hide resolved
...storage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/type.ts Outdated Show resolved Hide resolved
...storage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/type.ts Outdated Show resolved Hide resolved
...storage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/type.ts Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/models.ts Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/index.tsx Outdated Show resolved Hide resolved
...orage-plugin/src/components/create-storage-system/external-storage/ibm-flashsystem/models.ts
Comment on lines +4 to +5
label: 'IBM Flash System',
labelPlural: 'IBM Flash Systems',
Copy link
Contributor

@afreen23 afreen23 Jul 24, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In kind it says flashsystemcluster but in label it is flash system.
Is that a miss ? "IBM Flash System Cluster" ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be resolved later. Not blocking PR

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021
@shdn-ibm
fix: lint check error
6cdab14 
fix: lint error

fix: lint check error

fix: lint error

fix: rename management address in secret

fix: lint error

fix: lint error
@shdn-ibm
fix: refine code according to comments
650451a
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2021
@shdn-ibm
fix: code changes as comments
06c5084 
fix: update translation file

fix: lint error
afreen23
afreen23 approved these changes Jul 25, 2021
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, shdn-ibm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2021
@openshift-merge-robot openshift-merge-robot merged commit 22dd91f into openshift:master Jul 25, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
@shdn-ibm shdn-ibm deleted the feature/add-flashsystem branch July 27, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 approved these changes

@rawagner rawagner Awaiting requested review from rawagner

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shdn-ibm @afreen23 @spadgett @openshift-merge-robot