Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODC-6196-Remove the serviceMesh folder and add OWNERS file to service-mesh folder #9608

Merged
merged 1 commit into from Jul 23, 2021
Merged

ODC-6196-Remove the serviceMesh folder and add OWNERS file to service-mesh folder #9608

merged 1 commit into from Jul 23, 2021

Conversation

makambalaji
Copy link
Contributor

Jira Id:
https://issues.redhat.com/browse/ODC-6196

Acceptance Criteria:
Delete the serviceMesh folder and move the OWNERS file from serviceMesh folder to service-mesh folder

Refactoring Gherkin scripts criteria for approving PR:

  • Check the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]
  • Update the test cases count in Automation status confluence Report
  • Add @un-verified tag which are not verified by ODC QE

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2021
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit b16a8c4 into openshift:master Jul 23, 2021
@spadgett spadgett added this to the v4.9 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants