Add list page for Storage Systems and Inject it via Horizontal Nav #9609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
component/ceph
afreen23
suggested changes
Jul 23, 2021
Comment on lines
7
to
10
| const addStorage = (kind: K8sKind, resource: K8sResourceKind) => ({ | ||
| labelKey: 'ceph-storage-plguin~Add Capacity', | ||
| callback: () => addCapacityModal({ kind, ocsConfig: resource }), | ||
| }); |
There was a problem hiding this comment.
Can you check you are not getting any i18n errors ?
Otherwise do something like:
Suggested change
| const addStorage = (kind: K8sKind, resource: K8sResourceKind) => ({ | |
| labelKey: 'ceph-storage-plguin~Add Capacity', | |
| callback: () => addCapacityModal({ kind, ocsConfig: resource }), | |
| }); | |
| const addStorage = (kind: K8sKind, resource: K8sResourceKind) => ({ | |
| // t('ceph-storage-plguin~Add Capacity',) | |
| labelKey:t('ceph-storage-plguin~Add Capacity',), | |
| callback: () => addCapacityModal({ kind, ocsConfig: resource }), | |
| }); |
| ); | ||
| }; | ||
|
|
||
| const StorageSystemListPage: React.FC = (props) => { |
| @@ -0,0 +1,15 @@ | |||
| export enum ODFQueries { | |||
| LATENCY = 'LAT', | |||
There was a problem hiding this comment.
Suggested change
| LATENCY = 'LAT', | |
| LATENCY = 'LATENCY', |
There was a problem hiding this comment.
It's more for type checking. The value on the right side of enum really doesn't matter much..
afreen23
suggested changes
Jul 23, 2021
Comment on lines
+32
to
+49
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| export const normalizeMetrics: MetricNormalize = ( | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| _latency, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| _throughput, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| _rawCapacity, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| _usedCapacity, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| _iops, | ||
| ) => { | ||
| // Todo(bipuladh): Add parsing logic for above items | ||
| return { | ||
| metrics: {} as any, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Let's keep it as it is now. It's a skeleton and rest of parsing is dependent on this function's return type.
afreen23
suggested changes
Jul 23, 2021
Comment on lines
4
to
5
| // Operator uses`<kind>.<apiGroup>/<apiVersion>` don't ask why | ||
| export const getGVK = (weirdLabel: string) => { |
There was a problem hiding this comment.
Suggested change
| // Operator uses`<kind>.<apiGroup>/<apiVersion>` don't ask why | |
| export const getGVK = (weirdLabel: string) => { | |
| // Operator uses`<kind>.<apiGroup>/<apiVersion>` | |
| export const getGVK = (kind: string) => { |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh, vbnrh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Metrics are not supported as reliable Metrics Exporter is not present.
Will send a different PR to update
Add Storage.