Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled #9612

Merged
merged 1 commit into from Jul 29, 2021

Conversation

divyanshiGupta
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-6092

Root cause:
Select a chart version help text is shown for helm chart install/upgrade dropdowns even when they are disabled.

Solution:
Dont show the help text when the dropdowns are disabled.

Screenshots:
Screenshot 2021-07-24 at 5 39 10 PM
Screenshot 2021-07-24 at 5 41 02 PM

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 24, 2021
@openshift-ci openshift-ci bot added the component/helm Related to helm-plugin label Jul 24, 2021
@divyanshiGupta
Copy link
Contributor Author

/cc @debsmita1
/cc @rohitkrai03

@debsmita1
Copy link
Contributor

/cc @beaumorley

@openshift-ci openshift-ci bot requested a review from beaumorley July 26, 2021 11:54
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX decided to just remove the install helptext because it is repetitive.

This is not 100% the case for the upgrade variant which says "Select the version to upgrade to."

The trick to hide the help text if the dropdown is disabled is different then the expected results but is fine for me if UX is fine with that as well.

@debsmita1
Copy link
Contributor

UX decided to just remove the install helptext because it is repetitive.

This is not 100% the case for the upgrade variant which says "Select the version to upgrade to."

The trick to hide the help text if the dropdown is disabled is different then the expected results but is fine for me if UX is fine with that as well.

Are we not going to show the help text for the dropdown in the Install form when there is more than one version available?
Screenshot from 2021-07-26 22-13-54

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understand that is what UX accepted / recommended for the moment because the old help text doesn't help anyone.

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@jerolimov
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 27, 2021
@debsmita1
Copy link
Contributor

verified the changes
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, divyanshiGupta, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyanshiGupta divyanshiGupta changed the title Fix to hide help text if helm chart install/upgrade dropdown is disabled Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@divyanshiGupta: This pull request references Bugzilla bug 1987198, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit cac43c6 into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1987198 has been moved to the MODIFIED state.

In response to this:

Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/helm Related to helm-plugin kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants