New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled #9612
Bug 1987198: Fix to hide help text if helm chart install/upgrade dropdown is disabled #9612
Conversation
/cc @debsmita1 |
/cc @beaumorley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UX decided to just remove the install helptext because it is repetitive.
This is not 100% the case for the upgrade variant which says "Select the version to upgrade to."
The trick to hide the help text if the dropdown is disabled is different then the expected results but is fine for me if UX is fine with that as well.
6625122
to
dc4386f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my understand that is what UX accepted / recommended for the moment because the old help text doesn't help anyone.
/approve
/retest |
verified the changes |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, divyanshiGupta, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@divyanshiGupta: This pull request references Bugzilla bug 1987198, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@divyanshiGupta: All pull requests linked via external trackers have merged: Bugzilla bug 1987198 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-6092
Root cause:
Select a chart version
help text is shown for helm chart install/upgrade dropdowns even when they are disabled.Solution:
Dont show the help text when the dropdowns are disabled.
Screenshots:
/kind bug