Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1985948: (e2e)(flaky) vim fixture to import #9616

Merged
merged 3 commits into from Jul 26, 2021
Merged

Bug 1985948: (e2e)(flaky) vim fixture to import #9616

merged 3 commits into from Jul 26, 2021

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Jul 25, 2021

cypress fixtures may not be playing nice with our tests when running on prow.
this PR tests what happen if we use regular imports.

@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 25, 2021
@yaacov
Copy link
Member Author

yaacov commented Jul 25, 2021

This is a wip to check if fixtures are a cause of flakiness in the tests.
cc:// @avivtur @pcbailey @gouyang

@yaacov
Copy link
Member Author

yaacov commented Jul 25, 2021

/retest

@yaacov yaacov force-pushed the e2e-vim-fixture-to-import branch from 54a76c6 to f7040e6 Compare July 25, 2021 14:44
@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 25, 2021
@yaacov yaacov force-pushed the e2e-vim-fixture-to-import branch from f7040e6 to 8643674 Compare July 25, 2021 14:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2021
@yaacov
Copy link
Member Author

yaacov commented Jul 25, 2021

@glekner @metalice @avivtur @pcbailey @gouyang please review

@avivtur
Copy link
Contributor

avivtur commented Jul 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2021
@yaacov
Copy link
Member Author

yaacov commented Jul 25, 2021

/retest

1 similar comment
@yaacov
Copy link
Member Author

yaacov commented Jul 25, 2021

/retest

@gouyang
Copy link
Contributor

gouyang commented Jul 26, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, gouyang, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@yaacov yaacov changed the title (e2e)(flaky) vim fixture to import Bug 1985948: (e2e)(flaky) vim fixture to import Jul 26, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@yaacov: This pull request references Bugzilla bug 1985948, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1985948: (e2e)(flaky) vim fixture to import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 26, 2021
@openshift-ci openshift-ci bot requested a review from gouyang July 26, 2021 10:26
@yaacov
Copy link
Member Author

yaacov commented Jul 26, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 066001a into openshift:master Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@yaacov: All pull requests linked via external trackers have merged:

Bugzilla bug 1985948 has been moved to the MODIFIED state.

In response to this:

Bug 1985948: (e2e)(flaky) vim fixture to import

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelkosz jelkosz Awaiting requested review from jelkosz

@mareklibra mareklibra Awaiting requested review from mareklibra

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@gouyang gouyang

@avivtur avivtur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yaacov @avivtur @openshift-bot @gouyang @spadgett @openshift-merge-robot