Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1985737: Edit button boot order #9618

Merged

Conversation

metalice
Copy link
Contributor

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1985737

Screen shots / Gifs for design review:
After:
image
Before:
image

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2021

@metalice: This pull request references Bugzilla bug 1985737, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1985737: Edit button boot order

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Jul 25, 2021
@yaacov
Copy link
Member

yaacov commented Jul 25, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2021
@metalice
Copy link
Contributor Author

/test kubevirt-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0873366 into openshift:master Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1985737 has been moved to the MODIFIED state.

In response to this:

Bug 1985737: Edit button boot order

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants