Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986426: Fixes for odf and ibm integration #9629

Merged
merged 1 commit into from Jul 28, 2021

Conversation

afreen23
Copy link
Contributor

  • the value of plural should be flashsystemclusters
  • redirect to storage system list page
  • functions and constants need not be capitalized
  • removed inconsistency in naming wizard step files. All files to be suffixed with "step"
  • added right padding in the form
  • remove form tag inside form tags

Screenshot from 2021-07-26 19-04-58

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2021
@@ -19,6 +18,7 @@ import {
import { ErrorHandler } from '../../error-handler';
import { ExternalStorage } from '../../external-storage/types';
import { NO_PROVISIONER } from '../../../../constants';
import './backing-storage-step.scss';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming file

@@ -0,0 +1,3 @@
.odf-create-storage-class__form {
padding-right: 10rem;
}
Copy link
Contributor Author

@afreen23 afreen23 Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added right padding to create storage class form for better look and feel

@@ -1,7 +1,7 @@
export { BackingStorage } from './backing-storage-step/backing-storage-step';
export { CapacityAndNodes } from './capacity-and-nodes-step/capacity-and-nodes-step';
export { ConnectionDetails } from './connection-details-step';
export { CreateStorageClass } from './create-storage-class-step';
export { CreateStorageClass } from './create-storage-class-step/create-storage-class-step';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file renaming

 - the value of `plural` should be `flashsystemclusters`
 - redirect to storage system list page
 - functions and constants need not be capitalized
 - removed inconsistency in naming wizard step files. All files to be suffixed with "step"
 - added right padding in the form
 - remove form tag inside form tags
 - Poolname should have space in between

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@@ -33,7 +32,7 @@ export const FlashSystemConnectionDetails: React.FC<ExternalComponentProps<Flash
};

return (
<Form>
<>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

form tag already used in parent component. Hence removing.

@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, bipuladh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@afreen23 afreen23 changed the title (fix): Fixes for odf and ibm integration Bug 1986426: Fixes for odf and ibm integration Jul 27, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2021

@afreen23: This pull request references Bugzilla bug 1986426, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1986426: Fixes for odf and ibm integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 27, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 44b1072 into openshift:master Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@afreen23: All pull requests linked via external trackers have merged:

Bugzilla bug 1986426 has been moved to the MODIFIED state.

In response to this:

Bug 1986426: Fixes for odf and ibm integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants