New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1986426: Fixes for odf and ibm integration #9629
Bug 1986426: Fixes for odf and ibm integration #9629
Conversation
@@ -19,6 +18,7 @@ import { | |||
import { ErrorHandler } from '../../error-handler'; | |||
import { ExternalStorage } from '../../external-storage/types'; | |||
import { NO_PROVISIONER } from '../../../../constants'; | |||
import './backing-storage-step.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming file
@@ -0,0 +1,3 @@ | |||
.odf-create-storage-class__form { | |||
padding-right: 10rem; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added right padding to create storage class form for better look and feel
@@ -1,7 +1,7 @@ | |||
export { BackingStorage } from './backing-storage-step/backing-storage-step'; | |||
export { CapacityAndNodes } from './capacity-and-nodes-step/capacity-and-nodes-step'; | |||
export { ConnectionDetails } from './connection-details-step'; | |||
export { CreateStorageClass } from './create-storage-class-step'; | |||
export { CreateStorageClass } from './create-storage-class-step/create-storage-class-step'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file renaming
- the value of `plural` should be `flashsystemclusters` - redirect to storage system list page - functions and constants need not be capitalized - removed inconsistency in naming wizard step files. All files to be suffixed with "step" - added right padding in the form - remove form tag inside form tags - Poolname should have space in between Signed-off-by: Afreen Rahman <afrahman@redhat.com>
4fa7fda
to
d585534
Compare
@@ -33,7 +32,7 @@ export const FlashSystemConnectionDetails: React.FC<ExternalComponentProps<Flash | |||
}; | |||
|
|||
return ( | |||
<Form> | |||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form tag already used in parent component. Hence removing.
frontend/packages/ceph-storage-plugin/src/components/create-storage-system/footer.tsx
Show resolved
Hide resolved
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@afreen23: This pull request references Bugzilla bug 1986426, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@afreen23: All pull requests linked via external trackers have merged: Bugzilla bug 1986426 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
plural
should beflashsystemclusters