Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986676: Fix Unique key warning issue in P/PLR details page #9639

Merged

Conversation

karthikjeeyar
Copy link
Contributor

Fixes:

https://issues.redhat.com/browse/ODC-6162

Analysis / Root cause:

Browser log should not show any react warnings. Depending of the pipeline and pipeline run visualization shows a warning:

Solution Description:

Use linkname instead of name so the list item gets unique key for embeddedTasks as well.

Screen shots / Gifs for design review:

No React warnings on the browser log.

Test setup:

Use this yaml https://gist.github.com/karthikjeeyar/17be9d82ad999b0dea3de1c00483415b

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added the component/pipelines Related to pipelines-plugin label Jul 27, 2021
@karthikjeeyar karthikjeeyar changed the title Fix Unique key warning issue in P/PLR details page Bug 1986676: Fix Unique key warning issue in P/PLR details page Jul 28, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@karthikjeeyar: This pull request references Bugzilla bug 1986676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1986676: Fix Unique key warning issue in P/PLR details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 28, 2021
@nemesis09
Copy link
Contributor

/retest

@nemesis09
Copy link
Contributor

verified locally
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@nemesis09
Copy link
Contributor

/assign @jerolimov

Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are gone 👍

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, karthikjeeyar, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2167baa into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@karthikjeeyar: All pull requests linked via external trackers have merged:

Bugzilla bug 1986676 has been moved to the MODIFIED state.

In response to this:

Bug 1986676: Fix Unique key warning issue in P/PLR details page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/pipelines Related to pipelines-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants