New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1986676: Fix Unique key warning issue in P/PLR details page #9639
Bug 1986676: Fix Unique key warning issue in P/PLR details page #9639
Conversation
@karthikjeeyar: This pull request references Bugzilla bug 1986676, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind bug |
/retest |
verified locally |
/assign @jerolimov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warnings are gone 👍
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, karthikjeeyar, nemesis09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 1986676 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6162
Analysis / Root cause:
Browser log should not show any react warnings. Depending of the pipeline and pipeline run visualization shows a warning:
Solution Description:
Use linkname instead of name so the list item gets unique key for embeddedTasks as well.
Screen shots / Gifs for design review:
No React warnings on the browser log.
Test setup:
Use this yaml https://gist.github.com/karthikjeeyar/17be9d82ad999b0dea3de1c00483415b
Browser conformance: