New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1986729: Mark sink title as required form field #9654
Conversation
/cc @invincibleJai |
/retest |
@jerolimov: This pull request references Bugzilla bug 1986729, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, jerolimov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 1986729 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6201
https://bugzilla.redhat.com/show_bug.cgi?id=1986729
Analysis / Root cause:
When the user creates an event source the user should see an indicator if a field is required or not.
The form does not enable the submit button until a sink URI is entered. But the field is not marked as required.
Solution Description:
Mark the title as required with a patternfly class and a style to align the asterisk to the top.
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux
Unit test coverage report:
Unchanged
Test setup:
Unchanged
Browser conformance: