Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 4.7] Bug 1969754: windows vms fail to start rls 4.7 #9657

Conversation

metalice
Copy link
Contributor

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1969754

Solution Description:
Cherry pick from:
e5038f1
b839c32
a06937e

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@metalice: This pull request references Bugzilla bug 1969754, which is invalid:

  • expected dependent Bugzilla bug 1969756 to target a release in 4.8.0, 4.8.z, but it targets "2.6.6" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1969754: windows vms fail to start rls 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 28, 2021
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Jul 28, 2021
@yaacov
Copy link
Member

yaacov commented Jul 28, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@yaacov: This pull request references Bugzilla bug 1969754, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1942839 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1942839 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 28, 2021
@yaacov
Copy link
Member

yaacov commented Jul 28, 2021

@metalice hi, this fix is backporting 18 files and does more than just taking the image from the config map when available,
can you make a smaller backport that only take the image from the config map when available ?

@metalice
Copy link
Contributor Author

@metalice hi, this fix is backporting 18 files and does more than just taking the image from the config map when available,
can you make a smaller backport that only take the image from the config map when available ?

I wish I had. I actually clean a lot from it. but it combined from 3 commits. all those 18 files changes are needed otherwise it won't work.

@yaacov
Copy link
Member

yaacov commented Jul 28, 2021

/hold

I wish I had. I actually clean a lot from it. but it combined from 3 commits. all those 18 files changes are needed otherwise it won't work.

@metalice I'm sure you can make a better fix, we can't back-port 18 unrelated files for a small fix. can you ask who can help you make a better PR ?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@yaacov
Copy link
Member

yaacov commented Oct 4, 2021

/hold cancel

looks like we will not have time to make a smaller fix

/lgtm

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@yaacov
Copy link
Member

yaacov commented Oct 4, 2021

/retitle [release 4.7] Bug 1969754: windows vms fail to start rls 4.7

@openshift-ci openshift-ci bot changed the title Bug 1969754: windows vms fail to start rls 4.7 [release 4.7] Bug 1969754: windows vms fail to start rls 4.7 Oct 4, 2021
@jerpeter1 jerpeter1 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 583a9cd into openshift:release-4.7 Oct 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2021

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1969754 has been moved to the MODIFIED state.

In response to this:

[release 4.7] Bug 1969754: windows vms fail to start rls 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants