New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release 4.7] Bug 1969754: windows vms fail to start rls 4.7 #9657
[release 4.7] Bug 1969754: windows vms fail to start rls 4.7 #9657
Conversation
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice: This pull request references Bugzilla bug 1969754, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@yaacov: This pull request references Bugzilla bug 1969754, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@metalice hi, this fix is backporting 18 files and does more than just taking the image from the config map when available, |
I wish I had. I actually clean a lot from it. but it combined from 3 commits. all those 18 files changes are needed otherwise it won't work. |
/hold
@metalice I'm sure you can make a better fix, we can't back-port 18 unrelated files for a small fix. can you ask who can help you make a better PR ? |
/hold cancel looks like we will not have time to make a smaller fix /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: metalice, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle [release 4.7] Bug 1969754: windows vms fail to start rls 4.7 |
@metalice: All pull requests linked via external trackers have merged: Bugzilla bug 1969754 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1969754
Solution Description:
Cherry pick from:
e5038f1
b839c32
a06937e