Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986988: Add button around pipeline builder icon to make popover accessibly via keyboard #9666

Merged
merged 1 commit into from Jul 29, 2021

Conversation

jerolimov
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-6190
https://bugzilla.redhat.com/show_bug.cgi?id=1986988

Analysis / Root cause:
Icon is not reachable via keyboard without a button or tab-index.

Solution Description:
Add a button around the icon so that is reachable with the keyboard.

Screen shots / Gifs for design review:
reachable-button

Unit test coverage report:
Unchanged

Test setup:
Unchanged

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@jerolimov: This pull request references Bugzilla bug 1986988, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1986988: Add button around icon to make it accessibly via keyboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2021
@jerolimov jerolimov changed the title Bug 1986988: Add button around icon to make it accessibly via keyboard Bug 1986988: Add button around pipeline builder icon to make popover accessibly via keyboard Jul 28, 2021
@jerolimov
Copy link
Member Author

/cc @karthikjeeyar

const content = t(
"pipelines-plugin~Resources aren't in beta, so it is recommended to use workspaces instead.",
);

return (
<Popover aria-label={content} bodyContent={content}>
<InfoCircleIcon className="opp-pipeline-workspace-suggestion-icon" />
<Button isInline variant="link" aria-label={ariaLabel}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Button isInline variant="link" aria-label={ariaLabel}>
<Button isInline variant={ButtonVariant.link} aria-label={ariaLabel}>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Copy and pasted this from another place. :)

@vikram-raj Updated 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerolimov so you also fixed the other place, right? :)

@jerolimov
Copy link
Member Author

/retest

@nemesis09
Copy link
Contributor

verified locally.
has changes addressing review comments.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b0abb0f into openshift:master Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 1986988 has been moved to the MODIFIED state.

In response to this:

Bug 1986988: Add button around pipeline builder icon to make popover accessibly via keyboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/pipelines Related to pipelines-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants