New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1986988: Add button around pipeline builder icon to make popover accessibly via keyboard #9666
Conversation
@jerolimov: This pull request references Bugzilla bug 1986988, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @karthikjeeyar |
const content = t( | ||
"pipelines-plugin~Resources aren't in beta, so it is recommended to use workspaces instead.", | ||
); | ||
|
||
return ( | ||
<Popover aria-label={content} bodyContent={content}> | ||
<InfoCircleIcon className="opp-pipeline-workspace-suggestion-icon" /> | ||
<Button isInline variant="link" aria-label={ariaLabel}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Button isInline variant="link" aria-label={ariaLabel}> | |
<Button isInline variant={ButtonVariant.link} aria-label={ariaLabel}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Copy and pasted this from another place. :)
@vikram-raj Updated 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerolimov so you also fixed the other place, right? :)
/retest |
verified locally. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, nemesis09 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 1986988 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6190
https://bugzilla.redhat.com/show_bug.cgi?id=1986988
Analysis / Root cause:
Icon is not reachable via keyboard without a button or tab-index.
Solution Description:
Add a button around the icon so that is reachable with the keyboard.
Screen shots / Gifs for design review:
Unit test coverage report:
Unchanged
Test setup:
Unchanged
Browser conformance: