Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1986699: Differentiate between operators for install #9668

Merged
merged 1 commit into from Aug 25, 2021
Merged

Bug 1986699: Differentiate between operators for install #9668

merged 1 commit into from Aug 25, 2021

Conversation

rebeccaalpert
Copy link
Contributor

@rebeccaalpert rebeccaalpert commented Jul 28, 2021 •
edited

Console was showing the wrong install status for operators with the same display name but different catalog sources. We don't have a ton of data to work with, but adding some tighter logic seems to work for the case specified in the bug.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1986699.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@rebeccaalpert: This pull request references Bugzilla bug 1986699, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1986699: Differentiate between operators for install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/olm Related to OLM bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@rebeccaalpert: This pull request references Bugzilla bug 1986699, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei July 28, 2021 19:37
@rebeccaalpert
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@rebeccaalpert: This pull request references Bugzilla bug 1986699, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rebeccaalpert
Copy link
Contributor Author

/test e2e-gcp-console

TheRealJon
TheRealJon requested changes Aug 10, 2021
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue with this bug is not with the CSV logic. It's with the Subscription we are associating with each package. We are only using the package name to match Subscription to PackageManifest. This is not specific enough. We need to make sure that not only the package name matches, but also Subscription.spec.source matches PackageManifest.status.catalogSource, and Subscription.spec.sourceNamespace matche PackageManifest.status.catalogSourceNamespace`.

frontend/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-page.tsx Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@rebeccaalpert: This pull request references Bugzilla bug 1986699, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 1986699: Differentiate between operators for install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

TheRealJon
TheRealJon requested changes Aug 16, 2021
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes requested.

frontend/packages/operator-lifecycle-manager/src/components/operator-group.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/operator-group.tsx Outdated Show resolved Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx Outdated Show resolved Hide resolved
@rebeccaalpert rebeccaalpert force-pushed the operatorhub branch 6 times, most recently from 2484a0c to 8e76d0f Compare August 20, 2021 21:55
@rebeccaalpert
Bug 1986699: Differentiate between operators for install
49647b7 
Console was showing the wrong install status for operators with the same display name but different catalog sources. We don't have a ton of data to work with, but adding the package catalog source and namespace to the subscription finding function seems to work.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1986699
TheRealJon
TheRealJon approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebeccaalpert, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@rebeccaalpert
Copy link
Contributor Author

/test e2e-gcp-console

1 similar comment
@rebeccaalpert
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit f8031b3 into openshift:master Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@rebeccaalpert: All pull requests linked via external trackers have merged:

Bugzilla bug 1986699 has been moved to the MODIFIED state.

In response to this:

Bug 1986699: Differentiate between operators for install

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rebeccaalpert @TheRealJon @spadgett @openshift-merge-robot