Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1987047: Open current console in new window #9669

Merged
merged 1 commit into from Jul 30, 2021
Merged

Bug 1987047: Open current console in new window #9669

merged 1 commit into from Jul 30, 2021

Conversation

pcbailey
Copy link
Contributor

When using a console type other than the one that is opened by default and the "Open Console in New Window" button is clicked, the default console type is opened instead of the one that was being used when the button is clicked. This PR fixes that bug.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@pcbailey: This pull request references Bugzilla bug 1987047, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1987047: Open current console in new window

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from mareklibra and yaacov July 28, 2021 20:05
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2021
@pcbailey
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2021

@pcbailey: This pull request references Bugzilla bug 1987047, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gouyang July 28, 2021 20:08
@pcbailey pcbailey force-pushed the open-current-console-in-new-window branch from 8a812e0 to 052acc6 Compare July 28, 2021 20:09
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard component/monitoring Related to monitoring component/sdk Related to console-plugin-sdk component/shared Related to console-shared and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2021
@pcbailey pcbailey force-pushed the open-current-console-in-new-window branch from 052acc6 to 458a722 Compare July 28, 2021 20:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@yaacov
Copy link
Member

yaacov commented Jul 29, 2021

/retest

2 similar comments
@yaacov
Copy link
Member

yaacov commented Jul 29, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Jul 29, 2021

/retest

@yaacov
Copy link
Member

yaacov commented Jul 29, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@pcbailey
Copy link
Contributor Author

/test kubevirt-plugin

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d5d66fb into openshift:master Jul 30, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 30, 2021

@pcbailey: All pull requests linked via external trackers have merged:

Bugzilla bug 1987047 has been moved to the MODIFIED state.

In response to this:

Bug 1987047: Open current console in new window

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 3, 2021
@pcbailey pcbailey deleted the open-current-console-in-new-window branch October 26, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@yaacov yaacov Awaiting requested review from yaacov

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/monitoring Related to monitoring component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pcbailey @yaacov @openshift-bot @spadgett @openshift-merge-robot