New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate perspective extension from static to dynamic #9685
migrate perspective extension from static to dynamic #9685
Conversation
1d23e52
to
49eba84
Compare
838ed41
to
eb2f5ae
Compare
Propagate from epic: |
eb2f5ae
to
553c430
Compare
34ff0f7
to
dc1931d
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
b0fac5d
to
1d3a719
Compare
1d3a719
to
a436e6a
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@christianvogt Seems like you need to run |
/label qe-approved Verified on a cluster created using cluster bot. Everything works as expected. |
a436e6a
to
6343430
Compare
@rohitkrai03 ran |
/lgtm |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6343430
to
5270b16
Compare
rebased PR |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: https://issues.redhat.com/browse/CONSOLE-2570 https://issues.redhat.com/browse/ODC-6237
Migration of perspective extension from static to dynamic.
No UI changes.
Note that there are 2 test cases disabled in
console-app/src/__tests__/extension-checks/perspectives.spec.ts
because these test cases relied on loading static extensions only.Browser conformance:
cc @rohitkrai03 @spadgett @jamestalton