Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1988812: [e2e][flaky] Don't fail smoke tests if vm exist before test start #9687

Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Aug 1, 2021

In the smoke tests we use create to create a vm, but in some cases a test vm is already running and we don't want to fail the test if the vm exist before the test start running, apply will create the vm if needed, but will not fail the test if the vm exist.

@openshift-ci openshift-ci bot requested review from glekner and rhrazdil August 1, 2021 09:48
@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 1, 2021
@yaacov yaacov force-pushed the dont-fail-smoke-tests-if-vm-exist branch from e6a20da to 5348b01 Compare August 1, 2021 10:28
@yaacov yaacov changed the title [e2e][flaky] Don't fail smoke tests if vm exist before test start Bug 1988812: [e2e][flaky] Don't fail smoke tests if vm exist before test start Aug 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2021

@yaacov: This pull request references Bugzilla bug 1988812, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1988812: [e2e][flaky] Don't fail smoke tests if vm exist before test start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 1, 2021
@yaacov
Copy link
Member Author

yaacov commented Aug 1, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2021

@yaacov: This pull request references Bugzilla bug 1988812, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 1, 2021
@openshift-ci openshift-ci bot requested a review from gouyang August 1, 2021 10:32
@avivtur
Copy link
Contributor

avivtur commented Aug 1, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 4a93df7 into openshift:master Aug 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2021

@yaacov: All pull requests linked via external trackers have merged:

Bugzilla bug 1988812 has been moved to the MODIFIED state.

In response to this:

Bug 1988812: [e2e][flaky] Don't fail smoke tests if vm exist before test start

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants