Bug 1985164: Regular user cannot restore VM snapshot

[avivtur]

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1985164

Analysis / Root cause:
According to snapshot docs: https://docs.openshift.com/container-platform/4.7/virt/virtual_machines/virtual_disks/virt-managing-offline-vm-snapshots.html#virt-restoring-vm-from-snapshot-cli_virt-managing-offline-vm-snapshots
there is no need to pre-define owner reference, when doing so for a regular user it causes to permissions issues when trying to restore a snapshot.

Solution Description:
removing pre-defined owner reference, allowing to receive automated values

Screen shots / Gifs for design review:
before:

after:

Signed-off-by: Aviv Turgeman aturgema@redhat.com

[openshift-ci]

@avivtur: This pull request references Bugzilla bug 1985164, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1985164: Regular user cannot restore VM snapshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@avivtur: All pull requests linked via external trackers have merged:

• openshift/console#9693

Bugzilla bug 1985164 has been moved to the MODIFIED state.

In response to this:

Bug 1985164: Regular user cannot restore VM snapshot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yaacov]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@yaacov: #9693 failed to apply on top of branch "release-4.8":

Applying: Bug 1985164: Regular user cannot restore VM snapshot
Using index info to reconstruct a base tree...
M	frontend/packages/kubevirt-plugin/src/components/modals/snapshot-restore-modal/snapshot-restore-modal.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/kubevirt-plugin/src/components/modals/snapshot-restore-modal/snapshot-restore-modal.tsx
CONFLICT (content): Merge conflict in frontend/packages/kubevirt-plugin/src/components/modals/snapshot-restore-modal/snapshot-restore-modal.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1985164: Regular user cannot restore VM snapshot
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.