Bug 1982765: Networking - Services - Edit Pod Selector : An incomprehensible Japanese sentence #9701
Conversation
openshift-ci
bot
added
bugzilla/severity-low
openshift-ci
bot
added
component/core
|
@dtaylor113: This pull request references Bugzilla bug 1982765, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| messageKey="public~Determines the set of pods targeted by this {{kind: props.kind.label.toLowerCase()}}." | ||
| // t('public~Determines the set of pods targeted by this {{kind}}.') | ||
| messageKey="public~Determines the set of pods targeted by this {{kind}}." | ||
| messageVariables={{ kind: props.kind.label.toLowerCase() }} |
There was a problem hiding this comment.
We should check if there is a kind.labelKey and provide that if available over the kind.label.
There was a problem hiding this comment.
Hi @rebeccaalpert, do you mean like this:
messageKey={'public~Determines the set of pods targeted by this {{kind}}.'}
messageVariables={{ kind: props.kind.labelKey || props.kind.label.toLowerCase() }}
Doesn't seem right considering what I'm doing here:
{messageKey
? t(messageKey, messageVariables)
: t(
'public~Labels help you organize and select resources. Adding labels below will let you query for objects that have similar, overlapping or dissimilar labels.',
)}
There was a problem hiding this comment.
Yeah, we'd have to do something like messageVariables={{ kind: props.kind.labelKey ? t(props.kind.labelKey) : props.kind.label.toLowerCase() }}.
My concern is that we're not passing the lower-cased kind to translation at all. For example, in the Chinese language files, a service is localized as "服务." It seems like it would be confusing to have it as "服务" in some contexts and "service" in others.
There was a problem hiding this comment.
Ok, updated, thanks, now looks like:
…ensible Japanese sentence
dtaylor113
force-pushed
the
i18n-fix-japanese-pod-sentance
branch
from
6fc6c05
to
009f901
Compare
|
@dtaylor113: This pull request references Bugzilla bug 1982765, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, rebeccaalpert, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
@dtaylor113: An error was encountered searching for external tracker bugs for bug 1982765 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
could not unmarshal response body: invalid character '<' looking for beginning of value
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed i18n key variable error:
Before:
After: