Bug 1987171: When customizing boot source, password is shown in default font #9730
Conversation
|
@avivtur: Bugzilla bug 1987171 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
kind/i18n
|
/bugzilla refresh |
|
@avivtur: Bugzilla bug 1987171 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-medium
|
@yaacov: This pull request references Bugzilla bug 1987171, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| onClick={() => navigator.clipboard.writeText(cloudInitPassword)} | ||
| > | ||
| <CopyIcon /> | ||
| {t('kubevirt-plugin~Copy password')} |
There was a problem hiding this comment.
can we move the "copy password" help text to be a pop-over when user hover over the icon, and remove it from regular view ?
There was a problem hiding this comment.
btw/
can you make it an Accordion instead of an Alert
https://www.patternfly.org/v4/components/accordion
title of accordion will stay: "Guest login credentials"
but the content will only apear when open
and we can then remove the "Hide/Show password" behaviour because we get it from the accordion
the copy action will be nicer without the "Show/Hide"
There was a problem hiding this comment.
added, changed the after image in description
|
@avivtur: This pull request references Bugzilla bug 1987171, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@avivtur: This pull request references Bugzilla bug 1987171, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci
bot
added
lgtm
|
/lgtm |
…lt font Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
|
@avivtur: This pull request references Bugzilla bug 1987171, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (lkladnit@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@avivtur: All pull requests linked via external trackers have merged: Bugzilla bug 1987171 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1987171
Analysis / Root cause:
password font size is not clear enough
Solution Description:
changing alert to accordion component, and adding copy password button
Screen shots / Gifs for design review:
before:
after:
Signed-off-by: Aviv Turgeman aturgema@redhat.com