New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate workload resource actions to new extension based actions #9731
Migrate workload resource actions to new extension based actions #9731
Conversation
61bffc6
to
fcd4a7c
Compare
1e27dfb
to
459414c
Compare
459414c
to
fca530f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rohitkrai03 fro StatefulSets the order of actions seems to be changed
@sahil143 Yeah, I am trying to make it consistent in terms of where we place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
verified and tested locally
/lgtm cancel @Rohit I'm seeing this type error with
|
verified the changes looks good @sahil143 am not seeing this on |
@sahil143 I think you might need to pull my latest changes. The PR initially had that issue but i pushed a fix for it this morning. |
/lgtm With latest changes not seeing the error |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rohitkrai03, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved added docs-approved on behalf of the docs team as the epic has a doc-ack label. |
Fixes: https://issues.redhat.com/browse/ODC-6230
Analysis / Root cause: All workload resource actions need to use new extension based actions in order to update the resource side panel on topology.
Solution Description:
This PR migrate actions for list page and details page of following workload resources -
DeploymentConfig
StatefulSet
DaemonSet
Job
CronJob
Pod
Screen shots / Gifs for design review: No UI changes.
Browser conformance: