Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate workload resource actions to new extension based actions #9731

Merged

Conversation

rohitkrai03
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-6230

Analysis / Root cause: All workload resource actions need to use new extension based actions in order to update the resource side panel on topology.

Solution Description:
This PR migrate actions for list page and details page of following workload resources -

  • DeploymentConfig
  • StatefulSet
  • DaemonSet
  • Job
  • CronJob
  • Pod

Screen shots / Gifs for design review: No UI changes.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/sdk Related to console-plugin-sdk labels Aug 4, 2021
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 4, 2021
@rohitkrai03 rohitkrai03 force-pushed the workload-actions-migration branch 2 times, most recently from 1e27dfb to 459414c Compare August 5, 2021 10:35
@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Aug 5, 2021
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitkrai03 fro StatefulSets the order of actions seems to be changed
Screenshot 2021-08-05 at 5 29 51 PM
Screenshot 2021-08-05 at 5 29 56 PM

@rohitkrai03
Copy link
Contributor Author

@rohitkrai03 fro StatefulSets the order of actions seems to be changed
Screenshot 2021-08-05 at 5 29 51 PM
Screenshot 2021-08-05 at 5 29 56 PM

@sahil143 Yeah, I am trying to make it consistent in terms of where we place Edit pod count for all resources. It's at the top for Deployment so I've placed it at the top for all the others as well.

Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified and tested locally

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@sahil143
Copy link
Contributor

sahil143 commented Aug 5, 2021

/lgtm cancel

@Rohit I'm seeing this type error with yarn dev

ERROR in /Users/sahil/workspace/github/openshift/console/frontend/packages/console-shared/src/components/actions/loader/ActionsLoader.tsx(43,65):
TS2345: Argument of type 'ExtensionK8sKindVersionModel' is not assignable to parameter of type 'ExtensionK8sGroupModel'.
  Property 'group' is optional in type 'ExtensionK8sKindVersionModel' but required in type 'ExtensionK8sGroupModel'.
Version: typescript 3.8.3

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@invincibleJai
Copy link
Member

/lgtm cancel

@Rohit I'm seeing this type error with yarn dev

ERROR in /Users/sahil/workspace/github/openshift/console/frontend/packages/console-shared/src/components/actions/loader/ActionsLoader.tsx(43,65):
TS2345: Argument of type 'ExtensionK8sKindVersionModel' is not assignable to parameter of type 'ExtensionK8sGroupModel'.
  Property 'group' is optional in type 'ExtensionK8sKindVersionModel' but required in type 'ExtensionK8sGroupModel'.
Version: typescript 3.8.3

verified the changes looks good

@sahil143 am not seeing this on yarn dev

@rohitkrai03
Copy link
Contributor Author

/lgtm cancel

@Rohit I'm seeing this type error with yarn dev

ERROR in /Users/sahil/workspace/github/openshift/console/frontend/packages/console-shared/src/components/actions/loader/ActionsLoader.tsx(43,65):
TS2345: Argument of type 'ExtensionK8sKindVersionModel' is not assignable to parameter of type 'ExtensionK8sGroupModel'.
  Property 'group' is optional in type 'ExtensionK8sKindVersionModel' but required in type 'ExtensionK8sGroupModel'.
Version: typescript 3.8.3

@sahil143 I think you might need to pull my latest changes. The PR initially had that issue but i pushed a fix for it this morning.

@sahil143
Copy link
Contributor

sahil143 commented Aug 5, 2021

/lgtm

With latest changes not seeing the error

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@invincibleJai
Copy link
Member

/label qe-approved
/label docs-approved
/label px-approved

added docs-approved on behalf of the docs team as the epic has a doc-ack label.
added px-approved on behalf of the px team as the epic has a px-ack label.
Epic link: https://issues.redhat.com/browse/ODC-5712

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 6, 2021
@openshift-ci openshift-ci bot merged commit 63d7da9 into openshift:master Aug 6, 2021
@spadgett spadgett added this to the v4.9 milestone Aug 10, 2021
@rohitkrai03 rohitkrai03 deleted the workload-actions-migration branch August 11, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants