Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1986565: [OCP48][WebUI] "How to seal boot source for template usage" link points to /foo #9738

Merged
merged 1 commit into from Aug 5, 2021

Conversation

avivtur
Copy link
Contributor

@avivtur avivtur commented Aug 5, 2021

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1986565

Analysis / Root cause:
link pointing to meaningless address 'foo'

Solution Description:
replacing the link to
https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.3/html/virtual_machine_management_guide/chap-templates#Sealing_Virtual_Machines_in_Preparation_for_Deployment_as_Templates

Screen shots / Gifs for design review:

before:

bz-url-foo-before

after:

bz-url-foo-after

Signed-off-by: Aviv Turgeman aturgema@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@avivtur: This pull request references Bugzilla bug 1986565, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1986565: [OCP48][WebUI] "How to seal boot source for template usage" link points to /foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 5, 2021
@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Aug 5, 2021
@yaacov
Copy link
Member

yaacov commented Aug 5, 2021

note: not kubevirt doc exist yet, using ovirt documentation as placeholder until we have kubevirt specific docs

…ge" link points to /foo

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@yaacov
Copy link
Member

yaacov commented Aug 5, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@avivtur
Copy link
Contributor Author

avivtur commented Aug 5, 2021

/retest

@openshift-ci openshift-ci bot merged commit aa6fce5 into openshift:master Aug 5, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2021

@avivtur: All pull requests linked via external trackers have merged:

Bugzilla bug 1986565 has been moved to the MODIFIED state.

In response to this:

Bug 1986565: [OCP48][WebUI] "How to seal boot source for template usage" link points to /foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants