Gherkin for integration of tekton hub with pipeline builder #9747

sanketpathak · 2021-08-06T08:04:52Z

Epic: https://issues.redhat.com/browse/ODC-4315
Story: https://issues.redhat.com/browse/ODC-5972

Acceptance criteria:

Search/filter tasks
See task description
User can search for tasks that are available in the Tekton Hub and install the latest or a particular version of the Task on the cluster
User can upgrade tasks that are already installed on the cluster-
User can see which tasks are already installed within the search results from Tekton Hub

Checks required for approving Epic gherkin scripts PR:

Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
Add @to-do for automation possible scenarios
Add @regression or @smoke based on the importance of the scenario
Update the test scenarios count in Automation status confluence Report
Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

karthikjeeyar · 2021-08-16T07:56:11Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

@@ -27,7 +27,9 @@ Feature: Create the pipeline from builder page
        Scenario Outline: Create a pipeline with series tasks: P-02-TC02
            Given user is at Pipeline Builder page
             When user enters pipeline name as "<pipeline_name>"
-              And user selects "<task_name>" from Task drop down
+              And user clicks on Add task
+              And user searches "<task_name>" in quick search bar


Suggested change

And user searches "<task_name>" in quick search bar

And user searches "<cluster_task_name>" in quick search bar

karthikjeeyar · 2021-08-16T07:58:07Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

@@ -69,7 +75,9 @@ Feature: Create the pipeline from builder page
        Scenario Outline: Create pipeline with "<resource_type>" as resource type from pipeline builder page: P-02-TC05
            Given user is at Pipeline Builder page
             When user enters pipeline name as "<pipeline_name>"
-              And user selects "<task_name>" from Task drop down
+              And user clicks on Add task
+              And user searches "<task_name>" in quick search bar


Add option will be shown only for already installed clusterTask or namespace task through tektonhub. so change this in all the Add button scenarios to make it more readable.

Suggested change

And user searches "<task_name>" in quick search bar

And user searches "<cluster_task_name>" in quick search bar

karthikjeeyar · 2021-08-16T07:59:44Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+              And user searches "kn" in quick search bar
+              And user clicks on "Add" in "kn" task
+              And user adds a task in series
+              And user scrolls over to the newly added task


Suggested change

And user scrolls over to the newly added task

And user hovers over the newly added task

karthikjeeyar · 2021-08-16T08:00:05Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+              And user adds a task in series
+              And user scrolls over to the newly added task
+              And user clicks on delete icon
+             Then user can see the taks in series gets removed


Suggested change

Then user can see the taks in series gets removed

Then user can see the task in series gets removed

karthikjeeyar · 2021-08-16T08:01:37Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+            Given user is at Pipeline Builder page
+             When user enters pipeline name as "<pipeline_name>"
+              And user clicks on Add task
+              And user searches and select "<task_name>" in the list of items based on the provider="tekton" in quick search bar


Can we change like this ?

Suggested change

And user searches and select "<task_name>" in the list of items based on the provider="tekton" in quick search bar

And user searches and select "<task_name>" in the list of items based on the "tekton" provider in quick search bar

karthikjeeyar · 2021-08-16T08:05:11Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+              And user clicks on Add task
+              And user searches and select "<task_name>" in the list of items based on the provider="tekton" in quick search bar
+              And user clicks on "Install and Add" in "<task_name>" task 
+              And user clicks Create button on Pipeline Builder page


Suggested change

And user clicks Create button on Pipeline Builder page

And user should see the loading node until the installation is complete

And user should see the Create button enabled after installation

And user clicks Create button on Pipeline Builder page

gajanan-more

/lgtm

karthikjeeyar · 2021-08-19T10:10:15Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+              And user clicks on Add task
+              And user searches "openshift-client" in quick search bar
+              And user changes version to latest
+              And user clicks on "Updated and Add" button


Suggested change

And user clicks on "Updated and Add" button

And user clicks on "Update and Add" button

karthikjeeyar

I see you have added tektonHub scenarios

Install and Add
update and Add

Shall we also include Add flow, for already installed tektonhub or a ClusterTask ?

sanketpathak · 2021-08-19T11:34:41Z

@karthikjeeyar Updated the pr with Add flow scenario for already installed tektonhub tasks

karthikjeeyar

/lgtm

psrna · 2021-08-24T20:42:41Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+        @regression @to-do @odc-4315
+        Scenario Outline: Create a pipeline with TektonHub task present in cluster from pipeline builder page: P-02-TC010
+            Given user is at Pipeline Builder page
+              And user has installed tekton hub "<task_name>" kn in cluster


Suggested change

And user has installed tekton hub "<task_name>" kn in cluster

And user has installed tekton hub "<task_name>" task in cluster

psrna · 2021-08-24T20:43:51Z

...kages/pipelines-plugin/integration-tests/features/pipelines/create-from-builder-page.feature

+              And user clicks on "Update and Add" button
+              And user clicks Create button on Pipeline Builder page
+             Then user will be redirected to Pipeline Details page with header name "<pipeline_name>"
+


@sanketpathak Don't you miss the Examples section here?

Edited the name part

psrna · 2021-08-26T08:37:09Z

/lgtm

psrna · 2021-08-26T08:37:50Z

/approve

openshift-ci · 2021-08-26T08:39:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, karthikjeeyar, psrna, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/pipelines-plugin/integration-tests/OWNERS~~ [psrna]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sanketpathak · 2021-08-26T13:30:57Z

As this does not change feature code
/label px-approved
/label docs-approved
/label qe-approved

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2021

openshift-ci bot requested review from gajanan-more and praveen4g0 August 6, 2021 08:05

openshift-ci bot added the component/pipelines Related to pipelines-plugin label Aug 6, 2021

sanketpathak force-pushed the improve-pipeline-builder-tekton-hub-integration-ODC-4315 branch 3 times, most recently from cc3151e to 49e1293 Compare August 6, 2021 15:09

sanketpathak changed the title ~~[WIP] Gherkin for integration of tekton hub with pipeline builder~~ Gherkin for integration of tekton hub with pipeline builder Aug 6, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2021

sanketpathak force-pushed the improve-pipeline-builder-tekton-hub-integration-ODC-4315 branch from 49e1293 to 78f385f Compare August 6, 2021 15:17

karthikjeeyar reviewed Aug 16, 2021

View reviewed changes

sanketpathak force-pushed the improve-pipeline-builder-tekton-hub-integration-ODC-4315 branch from 78f385f to e0b2a0f Compare August 19, 2021 05:36

gajanan-more approved these changes Aug 19, 2021

View reviewed changes

openshift-ci bot assigned gajanan-more Aug 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

karthikjeeyar reviewed Aug 19, 2021

View reviewed changes

sanketpathak force-pushed the improve-pipeline-builder-tekton-hub-integration-ODC-4315 branch from e0b2a0f to 3415fad Compare August 19, 2021 11:32

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

karthikjeeyar approved these changes Aug 19, 2021

View reviewed changes

openshift-ci bot assigned karthikjeeyar Aug 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

psrna reviewed Aug 24, 2021

View reviewed changes

Gherkin for integration of tekton hub with pipeline builder-ODC-4315

28a1b22

sanketpathak force-pushed the improve-pipeline-builder-tekton-hub-integration-ODC-4315 branch from 3415fad to 28a1b22 Compare August 26, 2021 06:18

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021

openshift-ci bot assigned psrna Aug 26, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2021

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Aug 26, 2021

openshift-merge-robot merged commit 31a0082 into openshift:master Aug 26, 2021

spadgett added this to the v4.9 milestone Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gherkin for integration of tekton hub with pipeline builder #9747

Gherkin for integration of tekton hub with pipeline builder #9747

sanketpathak commented Aug 6, 2021 •

edited

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

karthikjeeyar Aug 16, 2021

sanketpathak Aug 19, 2021

gajanan-more left a comment

karthikjeeyar Aug 19, 2021

sanketpathak Aug 19, 2021

karthikjeeyar left a comment

sanketpathak commented Aug 19, 2021

karthikjeeyar left a comment

psrna Aug 24, 2021

sanketpathak Aug 26, 2021

psrna Aug 24, 2021

sanketpathak Aug 26, 2021 •

edited

psrna commented Aug 26, 2021

psrna commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021

sanketpathak commented Aug 26, 2021

	And user searches "<task_name>" in quick search bar
	And user searches "<cluster_task_name>" in quick search bar

	And user scrolls over to the newly added task
	And user hovers over the newly added task

	Then user can see the taks in series gets removed
	Then user can see the task in series gets removed

	And user searches and select "<task_name>" in the list of items based on the provider="tekton" in quick search bar
	And user searches and select "<task_name>" in the list of items based on the "tekton" provider in quick search bar

	And user clicks on "Updated and Add" button
	And user clicks on "Update and Add" button

	And user has installed tekton hub "<task_name>" kn in cluster
	And user has installed tekton hub "<task_name>" task in cluster

Gherkin for integration of tekton hub with pipeline builder #9747

Gherkin for integration of tekton hub with pipeline builder #9747

Conversation

sanketpathak commented Aug 6, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gajanan-more left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karthikjeeyar left a comment

Choose a reason for hiding this comment

sanketpathak commented Aug 19, 2021

karthikjeeyar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanketpathak Aug 26, 2021 • edited

Choose a reason for hiding this comment

psrna commented Aug 26, 2021

psrna commented Aug 26, 2021

openshift-ci bot commented Aug 26, 2021

sanketpathak commented Aug 26, 2021

sanketpathak commented Aug 6, 2021 •

edited

sanketpathak Aug 26, 2021 •

edited