Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2000636: reload entered data if any when switching strategies #9766

Merged

Conversation

debsmita1
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-6215

Root analysis:
On changing the strategy type, the default values for that type are being set to the formik context as a result when the user switches back to the previously selected type, the entered values / existing values for the type are not persisted.

Solution description:
Using the deploymentStrategy values of the formik context along with the default values for strategy type so that on switching strategies the user can see the last entered values for that strategy(if exists).

GIF:
deployment-strategy-type

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Aug 9, 2021
@debsmita1
Copy link
Contributor Author

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 9, 2021
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@divyanshiGupta
Copy link
Contributor

/hold
Need to test a few edge cases.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2021
@rottencandy
Copy link
Contributor

Not sure if it's expected but if I edit any DC and add only pre/post lifecycle hooks, the save button doesn't get enabled.

This seems to happen on master as well.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@debsmita1
Copy link
Contributor Author

Rebased

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2021
@divyanshiGupta
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2021
@debsmita1
Copy link
Contributor Author

debsmita1 commented Sep 2, 2021

Not sure if it's expected but if I edit any DC and add only pre/post lifecycle hooks, the save button doesn't get enabled.

This seems to happen on master as well.

Raised a separate ticket for this https://issues.redhat.com/browse/ODC-6314

@debsmita1 debsmita1 changed the title reload entered data if any when switching strategies Bug 2000636: reload entered data if any when switching strategies Sep 2, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@debsmita1: This pull request references Bugzilla bug 2000636, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 2000636: reload entered data if any when switching strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2021
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes. and it works as expected.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@divyanshiGupta
Copy link
Contributor

@debsmita1 tested it locally and it works fine.

/lgtm

@debsmita1
Copy link
Contributor Author

/assign @rohitkrai03
/assign @christianvogt

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, divyanshiGupta, rohitkrai03, rottencandy, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5772f32 into openshift:master Sep 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2021

@debsmita1: All pull requests linked via external trackers have merged:

Bugzilla bug 2000636 has been moved to the MODIFIED state.

In response to this:

Bug 2000636: reload entered data if any when switching strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants