New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2000636: reload entered data if any when switching strategies #9766
Bug 2000636: reload entered data if any when switching strategies #9766
Conversation
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the changes.
/lgtm
/hold |
Not sure if it's expected but if I edit any DC and add only pre/post lifecycle hooks, the save button doesn't get enabled. This seems to happen on master as well. |
a8bca0f
to
039a439
Compare
Rebased |
/hold cancel |
Raised a separate ticket for this https://issues.redhat.com/browse/ODC-6314 |
@debsmita1: This pull request references Bugzilla bug 2000636, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
039a439
to
bb346a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the changes. and it works as expected.
/lgtm
@debsmita1 tested it locally and it works fine. /lgtm |
/assign @rohitkrai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debsmita1, divyanshiGupta, rohitkrai03, rottencandy, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@debsmita1: All pull requests linked via external trackers have merged: Bugzilla bug 2000636 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-6215
Root analysis:
On changing the strategy type, the default values for that type are being set to the formik context as a result when the user switches back to the previously selected type, the entered values / existing values for the type are not persisted.
Solution description:
Using the deploymentStrategy values of the formik context along with the default values for strategy type so that on switching strategies the user can see the last entered values for that strategy(if exists).
GIF: