Gherkin: Generic managed service flow - topology #9768

sanketpathak · 2021-08-09T18:30:35Z

Epic: https://issues.redhat.com/browse/ODC-5722
Story: https://issues.redhat.com/browse/ODC-5962

Acceptance criteria:

Display bindable external services in topology as a trapezoid
Users can create binding connections to any bindable external service

Checks required for approving Epic gherkin scripts PR:

Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
Add @to-do for automation possible scenarios
Add @regression or @smoke based on the importance of the scenario
Update the test scenarios count in Automation status confluence Report
Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

sanketpathak · 2021-08-10T06:51:27Z

/assign @sahil143

sanketpathak · 2021-08-10T10:23:53Z

/cc @invincibleJai

sahil143 · 2021-08-11T07:39:32Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+        Scenario: Display of External Bindable resources: T-06-TC24
+            Given user has created external bindable resource
+             When user goes to Topology chart view
+             Then user will see the bindable resource in trapezoid shape


This scenario will also require us to install SBO

Added the step for it

sahil143

/lgtm

sanketpathak · 2021-08-19T09:21:57Z

/assign @makambalaji

gajanan-more · 2021-08-19T09:45:51Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+             When user created a deployment workload
+              And user drag the connector from the deployment workload 
+              And user drops the connector on the enabled bindable resource
+             Then user will see service binding connection 


Add the empty new line

gajanan-more

/lgtm

psrna · 2021-08-24T21:20:36Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

@@ -273,3 +273,22 @@ Feature: Topology chart area
              And user sees shortcut for Access create connector handle
              And user sees shortcut for Qpen quick search modal
              And user sees shortcut for Drag and drop a JAR file into Topology
+
+
+        @regression @manual @5722


We should be consistent with the tags. For everything that's not yet automated, do we use the tag @Manual, or @to-do? Similarly @ODC-5722 vs @5722. I've seen both looking on other PR's

If it's a manual scenario, then we are adding @Manual
@to-do, If the scenario is able to automate, but not yet automated. then we will add this tag
@sanketpathak - Please update the epic number as @ODC-5722

makambalaji · 2021-08-31T05:21:43Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+        @regression @manual @odc-5722
+        Scenario: Display of External Bindable resources: T-06-TC24
+            Given user has installed Service Binding operator
+              And user has created external bindable resource


Can we add the steps to create external bindable resource with in this scenario, so that while executing this scenario. It is easier.
Include the test data as well

We can only use kafka connection(RHOAS) as of now for the external bindable resource, I'll rewrite it as:
user has created external bindable resource Kafka Connection "kafka-instance-123"

makambalaji · 2021-08-31T05:21:56Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+        Scenario: Display of External Bindable resources: T-06-TC24
+            Given user has installed Service Binding operator
+              And user has created external bindable resource
+             When user goes to Topology chart view


Suggested change

When user goes to Topology chart view

When user navigates to Topology chart view

makambalaji · 2021-08-31T05:22:25Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+            Given user has installed Service Binding operator
+              And user has created external bindable resource
+             When user goes to Topology chart view
+             Then user will see the bindable resource in trapezoid shape


Include the test data in this step

Updated in the statement

makambalaji · 2021-08-31T05:23:28Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+        @regression @manual @odc-5722
+        Scenario: Connect to External Bindable resources: T-06-TC25
+            Given user has installed Service Binding operator
+              And user has created external bindable resource


Provide the data which is used in above scenario

Updated in the statement

makambalaji · 2021-08-31T05:24:19Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+             When user created a deployment workload
+              And user drag the connector from the deployment workload
+              And user drops the connector on the enabled bindable resource
+             Then user will see service binding connection


Provide the test data here

Same as above

makambalaji · 2021-08-31T09:56:20Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+            #Please refer to test case KM-01-TC01 for creating kafka connection
+              And user has created external bindable resource Kafka Connection "kafka-instance-123"
+             When user navigates to Topology chart view
+             Then user will see the bindable resource in trapezoid shape


Suggested change

Then user will see the bindable resource in trapezoid shape

Then user will see the bindable resource "kafka-instance-123" in trapezoid shape

makambalaji · 2021-08-31T09:56:59Z

...end/packages/topology/integration-tests/features/topology/topology-chart-area-visual.feature

+            #Please refer to test case KM-01-TC01 for creating kafka connection
+              And user has created external bindable resource Kafka Connection "kafka-instance-123"
+              And user is at the Topology chart view
+             When user created a deployment workload


Please add deployment workload name

…hown as trapezoid in topology-ODC-5722

makambalaji · 2021-08-31T10:07:24Z

/approve

makambalaji · 2021-08-31T10:07:31Z

/label px-approved
/label docs-approved
/label qe-approved

makambalaji · 2021-08-31T10:09:19Z

/approve

makambalaji · 2021-09-01T04:53:03Z

/lgtm

openshift-ci · 2021-09-01T04:53:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, makambalaji, sahil143, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/topology/integration-tests/OWNERS~~ [makambalaji]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the component/topology Related to topology label Aug 9, 2021

openshift-ci bot requested review from divyanshiGupta and gajanan-more August 9, 2021 18:30

openshift-ci bot assigned sahil143 Aug 10, 2021

openshift-ci bot requested a review from invincibleJai August 10, 2021 10:23

sahil143 suggested changes Aug 11, 2021

View reviewed changes

sanketpathak force-pushed the gherkin-generic-managed-service-flow-topology branch from e36b803 to 5b4de3d Compare August 11, 2021 11:04

sahil143 approved these changes Aug 16, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021

openshift-ci bot assigned makambalaji Aug 19, 2021

gajanan-more suggested changes Aug 19, 2021

View reviewed changes

sanketpathak force-pushed the gherkin-generic-managed-service-flow-topology branch from 5b4de3d to ea28856 Compare August 19, 2021 10:11

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

gajanan-more approved these changes Aug 19, 2021

View reviewed changes

openshift-ci bot assigned gajanan-more Aug 19, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2021

psrna reviewed Aug 24, 2021

View reviewed changes

sanketpathak force-pushed the gherkin-generic-managed-service-flow-topology branch from ea28856 to 20cabce Compare August 30, 2021 14:40

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021

makambalaji reviewed Aug 31, 2021

View reviewed changes

sanketpathak force-pushed the gherkin-generic-managed-service-flow-topology branch from 20cabce to 6ed00d3 Compare August 31, 2021 09:52

makambalaji suggested changes Aug 31, 2021

View reviewed changes

Gherkin:create binding connections to any bindable external service s…

91c4ae2

…hown as trapezoid in topology-ODC-5722

sanketpathak force-pushed the gherkin-generic-managed-service-flow-topology branch from 6ed00d3 to 91c4ae2 Compare August 31, 2021 10:04

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 31, 2021

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Aug 31, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021

openshift-merge-robot merged commit eb8837b into openshift:master Sep 1, 2021

spadgett added this to the v4.9 milestone Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gherkin: Generic managed service flow - topology #9768

Gherkin: Generic managed service flow - topology #9768

sanketpathak commented Aug 9, 2021 •

edited

sanketpathak commented Aug 10, 2021

sanketpathak commented Aug 10, 2021

sahil143 Aug 11, 2021

sanketpathak Aug 11, 2021

sahil143 left a comment

sanketpathak commented Aug 19, 2021

gajanan-more Aug 19, 2021

sanketpathak Aug 19, 2021

gajanan-more left a comment

psrna Aug 24, 2021

makambalaji Aug 30, 2021

sanketpathak Aug 30, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji Aug 31, 2021

sanketpathak Aug 31, 2021

makambalaji commented Aug 31, 2021

makambalaji commented Aug 31, 2021

makambalaji commented Aug 31, 2021

makambalaji commented Sep 1, 2021

openshift-ci bot commented Sep 1, 2021

	When user goes to Topology chart view
	When user navigates to Topology chart view

	Then user will see the bindable resource in trapezoid shape
	Then user will see the bindable resource "kafka-instance-123" in trapezoid shape

Gherkin: Generic managed service flow - topology #9768

Gherkin: Generic managed service flow - topology #9768

Conversation

sanketpathak commented Aug 9, 2021 • edited

sanketpathak commented Aug 10, 2021

sanketpathak commented Aug 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sahil143 left a comment

Choose a reason for hiding this comment

sanketpathak commented Aug 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gajanan-more left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

makambalaji commented Aug 31, 2021

makambalaji commented Aug 31, 2021

makambalaji commented Aug 31, 2021

makambalaji commented Sep 1, 2021

openshift-ci bot commented Sep 1, 2021

sanketpathak commented Aug 9, 2021 •

edited