Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1993306: Disable broken Event Sources on default Developer Catalog test #9800

Merged
merged 1 commit into from Aug 13, 2021

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Aug 12, 2021

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1993306

Analysis / Root cause:
The developer-catalog-details.feature installs the Serverless operator but don't create the knative-eventing resource. After that the following tests doesn't pass because the developer catalog doesn't show the "Event Sources" item.

  1) Developer Catalog Page
       Event Sources on default Developer Catalog: A-09-TC04:
     AssertionError: Timed out retrying after 40000ms: Expected to find element: `[data-test="tab EventSource"]`, but never found it.
      at Object.selectCatalogType (https://console-openshift-console.apps.ci-op-v4cvmdmx-75d12.**********************/__cypress/tests?p=features/addFlow/developer-catalog-details.feature:44603:20)

Solution Description:
Created ticket ODC-6249 to check that the knative-eventing resource is created correctly and disable the broken test for now.

Screen shots / Gifs for design review:
Screenshot from 2021-08-12 20-40-26

Unit test coverage report:
Unchanged

Test setup:

  1. Do NOT install the Serverless operator manually
  2. Run yarn test-cypress-dev-console and start developer-catalog-details.feature

Browser conformance:
Not relevant

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@jerolimov: This pull request references Bugzilla bug 1993306, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1993306: Disable broken Event Sources on default Developer Catalog test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 12, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@jerolimov: This pull request references Bugzilla bug 1993306, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1993306: Disable broken Event Sources on default Developer Catalog test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 12, 2021
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2021
@jerolimov
Copy link
Member Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

@jerolimov: This pull request references Bugzilla bug 1993306, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 12, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2021
@openshift-ci openshift-ci bot merged commit 921224a into openshift:master Aug 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2021

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 1993306 has been moved to the MODIFIED state.

In response to this:

Bug 1993306: Disable broken Event Sources on default Developer Catalog test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants