Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1996116: Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp #9816

Merged
merged 1 commit into from Aug 25, 2021
Merged

Bug 1996116: Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp #9816

merged 1 commit into from Aug 25, 2021

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Aug 17, 2021 •
edited

Issue: https://issues.redhat.com/browse/RHSTOR-2111

Signed-off-by: Gowtham Shanmugasundaram gshanmug@redhat.com

@openshift-ci openshift-ci bot added the component/ceph Related to ceph-storage-plugin label Aug 17, 2021
@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam
Copy link
Contributor Author

image

@GowthamShanmugam GowthamShanmugam changed the title Disabling pool dashboard menuactions for default pool, external cluster and for deletion timestamp Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp Aug 17, 2021
bipuladh
bipuladh reviewed Aug 18, 2021
View reviewed changes
frontend/packages/ceph-storage-plugin/src/components/block-pool/block-pool-details-page.tsx Outdated
import { BlockPoolDashboard } from '../dashboards/block-pool/block-pool-dashboard';

const BlockPoolDetailsPage: React.FC<React.ComponentProps<typeof DetailsPage>> = (props) => {
const { editYaml } = navFactory;
const { t } = useTranslation();

// Hooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Hooks

nit: Any function with use is a Hook. No need for the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@TimothyAsirJeyasing
Copy link
Contributor

How about mentioning "No Storage Class" if no storageclasses are present instead of "0" or "-" ?

@GowthamShanmugam GowthamShanmugam changed the title Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp Bug 1996116: Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp Aug 20, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2021

@GowthamShanmugam: This pull request references Bugzilla bug 1996116, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ratamir@redhat.com), skipping review request.

In response to this:

Bug 1996116: Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GowthamShanmugam
Copy link
Contributor Author

How about mentioning "No Storage Class" if no storageclasses are present instead of "0" or "-" ?

since it is a inventory card we better show in numbers

@GowthamShanmugam
Copy link
Contributor Author

/retest

bipuladh
bipuladh reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 25, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2021
@GowthamShanmugam
Disabling pool dashboard menuactions for default pool, external clust…
1cb7727 
…er and for deletion timestamp

Signed-off-by: Gowtham Shanmugasundaram <gshanmug@redhat.com>
@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 25, 2021
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 95f8576 into openshift:master Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@GowthamShanmugam: All pull requests linked via external trackers have merged:

Bugzilla bug 1996116 has been moved to the MODIFIED state.

In response to this:

Bug 1996116: Disabling pool dashboard menu actions for default pool, external cluster and for deletion timestamp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@shyRozen shyRozen Awaiting requested review from shyRozen

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GowthamShanmugam @TimothyAsirJeyasing @openshift-bot @bipuladh @spadgett @openshift-merge-robot