adds support for export app in topology #9817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
component/topology
invincibleJai
force-pushed
the
odc-6213
branch
5 times, most recently
from
8ed2f3e
to
615123f
Compare
invincibleJai
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
invincibleJai
force-pushed
the
odc-6213
branch
3 times, most recently
from
34fed8c
to
3bc30c7
Compare
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
odc-6213
branch
3 times, most recently
from
d5c5af6
to
69851d9
Compare
debsmita1
suggested changes
Aug 19, 2021
frontend/packages/topology/src/components/export-app/ExportApplication.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
odc-6213
branch
2 times, most recently
from
dde389b
to
08b1c1a
Compare
|
@debsmita1 @karthikjeeyar have updated , ptal |
|
Verified locally |
openshift-ci
bot
added
the
qe-approved
frontend/packages/topology/src/components/export-app/export-app-context.ts
Outdated
Show resolved
Hide resolved
frontend/packages/topology/src/components/export-app/ExportApplication.tsx
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
odc-6213
branch
from
08b1c1a
to
be7443b
Compare
invincibleJai
force-pushed
the
odc-6213
branch
from
be7443b
to
10234fa
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label docs-approved |
openshift-ci
bot
added
docs-approved
|
/retest |
|
|
||
| const exportAppClickHandle = async () => { | ||
| try { | ||
| setIsCreating(true); |
There was a problem hiding this comment.
Start an export and then click the export button again to see the modal.
In another window delete the export resource. You will be unable to start the export in the first window again because this flag is set.
There was a problem hiding this comment.
thanks, this has been addressed as part of #9864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-6213
Solution Description:
adds support for export app in topology
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Export Applicationin topology filter barRepo link :
https://github.com/cooktheryan/gitops-primer
https://github.com/cooktheryan/gitops-primer#deploying
Browser conformance: