-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1994586: Create local volume set step says "An error has occurred" #9818
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ import { AdvancedSection } from './advanced-section'; | |
import { SUPPORTED_EXTERNAL_STORAGE } from '../../external-storage'; | ||
import { StorageSystemKind } from '../../../../types'; | ||
import { getStorageSystemKind } from '../../../../utils/create-storage-system'; | ||
import { filterSCWithoutNoProv } from '../../../../utils/install'; | ||
import { WizardState, WizardDispatch } from '../../reducer'; | ||
import { | ||
BackingStorageType, | ||
|
@@ -78,7 +77,6 @@ const StorageClassSelection: React.FC<StorageClassSelectionProps> = ({ dispatch, | |
noSelection | ||
onChange={onStorageClassSelect} | ||
selectedKey={selected.name} | ||
filter={filterSCWithoutNoProv} | ||
data-test="storage-class-dropdown" | ||
/> | ||
</div> | ||
|
@@ -152,10 +150,15 @@ export const BackingStorage: React.FC<BackingStorageProps> = ({ | |
|
||
const onRadioSelect = (_, event) => { | ||
dispatch({ type: 'backingStorage/setType', payload: event.target.value }); | ||
dispatch({ | ||
type: 'wizard/setStepIdReached', | ||
payload: 1, | ||
}); | ||
if (stepIdReached !== 1) { | ||
// Reset the wizard when a new flow is selected | ||
// Avoid resetting when user has not visited any step other than this | ||
dispatch({ type: 'wizard/setInitialState' }); | ||
dispatch({ | ||
type: 'wizard/setStepIdReached', | ||
payload: 1, | ||
}); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's the same without this if condition. Maybe adding this condition will create some confusion while reading the code. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nope , think of the case when user will move back and forth. It s necessary when user went through a flow but thinks he wants to come back and go with another flow. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can add this as a comment , to make it clear. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a comment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ack |
||
}; | ||
|
||
return ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we now make internal mode cluster with
no-prov
storage-class as well ??There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah , we have removed notion of internal and external mode.