Bug 1995523: Add checks for annotations in pipeline quicksearch utils

[karthikjeeyar]

Fixes:

https://issues.redhat.com/browse/ODC-6255

Analysis / Root cause:

The Pipeline builder form throws Cannot read property 'openshift.io/installed-from' of undefined error when clicked on Add task button

Solution Description:

Added checks to metadata annotations, to avoid the NPE

Screen shots / Gifs for design review:

No UI change, shouldn't see the UI breaking.

Unit test coverage report:

  isInstalledNamespaceTask
      ✓ should return false if the annotations are missing in the metadata (1ms)
  findInstalledTask
      ✓ should return undefined if the annotations are missing in the metadata (1ms)

Test setup:

1. Create a pipeline task using the default yaml
2. Goto Pipeline Builder form
3. Click on Add task
   Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[karthikjeeyar]

/kind bug
/assign @debsmita1

[debsmita1]

verified the changes
/lgtm

[rohitkrai03]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[karthikjeeyar]

/bugzilla refresh

[openshift-ci]

@karthikjeeyar: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1995523 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1995523: Add checks for annotations in pipeline quicksearch utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/bugzilla refresh

[openshift-ci]

@karthikjeeyar: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1995523 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@karthikjeeyar: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1995523 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/bugzilla refresh

[openshift-ci]

@karthikjeeyar: This pull request references Bugzilla bug 1995523, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@karthikjeeyar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	f55ec3f	link	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@karthikjeeyar: All pull requests linked via external trackers have merged:

• openshift/console#9820

Bugzilla bug 1995523 has been moved to the MODIFIED state.

In response to this:

Bug 1995523: Add checks for annotations in pipeline quicksearch utils

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.