Gherkin form based edit build config #9840

sanketpathak · 2021-08-19T15:32:10Z

Epic: https://issues.redhat.com/browse/ODC-5008
Story: https://issues.redhat.com/browse/ODC-5968

Acceptance criteria:

The Edit Build Config action should allow the user to have a form driven experience
The Edit Build Config form driven experience should support the same features that were supported in 3.x

Checks required for approving Epic gherkin scripts PR:

Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
Add @to-do for automation possible scenarios
Add @regression or @smoke based on the importance of the scenario
Update the test scenarios count in Automation status confluence Report
Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

sanketpathak · 2021-08-19T15:42:26Z

/assign @divyanshiGupta @gajanan-more

sanketpathak · 2021-08-19T15:42:43Z

/cc @jerolimov

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

gajanan-more

/lgtm

jerolimov

Looks good so far, added some small comments about cleanup yaml files and some alignments with the current implementation in WIP PR #9834

jerolimov · 2021-08-20T11:19:00Z

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

+             When user navigates to build tab
+              And user clicks on kebab menu for "nodejs-ex-git1" build config
+              And user clicks on Edit BuildConfig
+             Then user will see the Git Repository url, Image configuration, Environment Variables


The name field should also be also shown:

Suggested change

Then user will see the Git Repository url, Image configuration, Environment Variables

Then user will see the Name, Git repository url, Image configuration, Environment Variables

Btw. Isn't it easier later to implement this when you check things seperate?

Suggested change

Then user will see the Git Repository url, Image configuration, Environment Variables

Then user will see the "Name" field

And user will see the "Git repo URL" field

And user will see the "Images" section

And user will see the "Environment Variables" section

This is really just a question as I don't implemented these page objects and actions later.

jerolimov · 2021-08-20T11:22:40Z

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

+             When user clicks on Show advanced options
+             Then user will see the Triggers, Build Secret, Run Policy, Post-Commit Hooks


The user needs multiple clicks because that are multiple advanced options similar to the add page.

Maybe like this: ... Or you create multiple tests for each case?

Suggested change

When user clicks on Show advanced options

Then user will see the Triggers, Build Secret, Run Policy, Post-Commit Hooks

When user clicks on Advanced option "Triggers"

And user clicks on Advanced option "Secrets"

And user clicks on Advanced option "Run Policy"

And user clicks on Advanced option "Hooks"

Then user will see section "Triggers"

And user will see section "Build Secret"

And user will see section "Run Policy"

And user will see section "Hooks"

jerolimov · 2021-08-20T11:29:21Z

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

+        Scenario: Edit Advanced git options of buildconfig which uses strategy Docker and Git as source: EBC-01-TC05
+        # user can use buildconfig-with-strategy-docker-source-git.yaml from testData/yamls/BuildConfig
+            Given user has applied the yaml "buildconfig-with-strategy-docker-source-git.yaml"
+              And user is at Edit Build Config page


Suggested change

And user is at Edit Build Config page

And user is at Edit Build Config page of deployment "flask-app-12"

jerolimov · 2021-08-20T11:31:35Z

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

+        # user can use buildconfig-with-strategy-docker-source-dockerfile.yaml from testData/yamls/BuildConfig
+            Given user has applied the yaml "buildconfig-with-strategy-docker-source-dockerfile.yaml"
+             When user clicks on action menu of build config
+              And user selects the option Edit BuildConfig


Above you used an sentence which brings you directly to this page. You should/could use it here as well or?

Suggested change

# user can use buildconfig-with-strategy-docker-source-dockerfile.yaml from testData/yamls/BuildConfig

Given user has applied the yaml "buildconfig-with-strategy-docker-source-dockerfile.yaml"

When user clicks on action menu of build config

And user selects the option Edit BuildConfig

# user can use buildconfig-with-strategy-docker-source-dockerfile.yaml from testData/yamls/BuildConfig

Given user has applied the yaml "buildconfig-with-strategy-docker-source-dockerfile.yaml"

And user is at Edit Build Config page of deployment "flask-app-12"

jerolimov · 2021-08-20T11:32:21Z

frontend/packages/dev-console/integration-tests/features/build-config/edit-build-config.feature

+              And user goes to Environment tab
+             Then user will see Name as "<name>" and and Value as "<value>"


There is no environment tab.

Suggested change

And user goes to Environment tab

Then user will see Name as "<name>" and and Value as "<value>"

Then user will see Name as "<name>" and and Value as "<value>" in Environment Variables

jerolimov · 2021-08-20T11:34:39Z

...ntegration-tests/testData/yamls/BuildConfig/buildconfig-with-strategy-docker-source-git.yaml

+  creationTimestamp: '2021-05-04T07:39:42Z'
+  generation: 2


Drop this lines, they will be generated by kubernetes

Suggested change

creationTimestamp: '2021-05-04T07:39:42Z'

generation: 2

jerolimov · 2021-08-20T11:34:43Z

...ntegration-tests/testData/yamls/BuildConfig/buildconfig-with-strategy-docker-source-git.yaml

+  resourceVersion: '1303043788'
+  selfLink: /apis/build.openshift.io/v1/namespaces/aut-form-edit-build-config/buildconfigs/flask-app-12
+  uid: e3927409-acab-11eb-8ed8-42010a8e0002


Drop this lines, they will be generated by kubernetes

Suggested change

resourceVersion: '1303043788'

selfLink: /apis/build.openshift.io/v1/namespaces/aut-form-edit-build-config/buildconfigs/flask-app-12

uid: e3927409-acab-11eb-8ed8-42010a8e0002

jerolimov · 2021-08-20T11:34:58Z

...gration-tests/testData/yamls/BuildConfig/buildconfig-with-strategy-source-source-binary.yaml

+  uid: cd73cce1-75b4-484e-9b35-f6c9dc3ed8b6
+  creationTimestamp: '2021-05-04T07:45:14Z'
+  generation: 2


Drop this lines, they will be generated by kubernetes

Suggested change

uid: cd73cce1-75b4-484e-9b35-f6c9dc3ed8b6

creationTimestamp: '2021-05-04T07:45:14Z'

generation: 2

jerolimov · 2021-08-20T11:35:02Z

...gration-tests/testData/yamls/BuildConfig/buildconfig-with-strategy-source-source-binary.yaml

+    openshift.io/build-config.name: fruits-app-1
+    openshift.io/build.number: '1'
+    openshift.io/build.pod-name: fruits-app-1-1-build
+  resourceVersion: '338752'


Drop this lines, they will be generated by kubernetes

Suggested change

resourceVersion: '338752'

jerolimov · 2021-08-20T11:35:58Z

...gration-tests/testData/yamls/BuildConfig/buildconfig-with-strategy-source-source-binary.yaml

+    - apiVersion: build.openshift.io/v1
+      kind: BuildConfig
+      name: fruits-app-1
+      uid: 44291715-6933-4fac-82f1-481ea0fe7f29


Drop this lines, they will be generated by kubernetes

Suggested change

uid: 44291715-6933-4fac-82f1-481ea0fe7f29

When I tried YAML on cluster it threw an error saying this uid is reuired so I've not removed this one

jerolimov · 2021-08-21T11:17:44Z

Thanks for applying my recommended changes and checking the yaml files. Restore the lgtm from @gajanan-more

/lgtm
/approve

openshift-ci · 2021-08-21T11:19:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, jerolimov, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/integration-tests/OWNERS~~ [jerolimov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-08-21T11:23:22Z

@jerolimov: The label(s) /label doc-approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed

In response to this:

Epic has a doc-ack and px-ack, so approving this on behalf of doc and PX team.

Because this PR only contains disabled (for the moment) gherkin scripts I'm also approving this also for QE.

Cypress skips this new scenarios:

/label doc-approved
/label px-approved
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jerolimov · 2021-08-21T11:23:39Z

Epic has a doc-ack and px-ack, so approving this on behalf of doc and PX team.

Because this PR only contains disabled (for the moment) gherkin scripts I'm also approving this also for QE.

Cypress skips this new scenarios:

/label docs-approved
/label px-approved
/label qe-approved

openshift-bot · 2021-08-21T13:33:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T13:46:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T18:06:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-21T18:18:44Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci bot requested review from gajanan-more and rottencandy August 19, 2021 15:32

openshift-ci bot added the component/dev-console Related to dev-console label Aug 19, 2021

sanketpathak force-pushed the gherkin-form-based-edit-build-config branch 2 times, most recently from 5d0183e to 69b766f Compare August 19, 2021 15:37

openshift-ci bot assigned divyanshiGupta and gajanan-more Aug 19, 2021

openshift-ci bot requested a review from jerolimov August 19, 2021 15:42

gajanan-more suggested changes Aug 20, 2021

View reviewed changes

sanketpathak force-pushed the gherkin-form-based-edit-build-config branch 3 times, most recently from 6c85b01 to a5c38ba Compare August 20, 2021 10:28

gajanan-more approved these changes Aug 20, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021

jerolimov reviewed Aug 20, 2021

View reviewed changes

Gherkin for form based edit for Build Configs

8580cf1

sanketpathak force-pushed the gherkin-form-based-edit-build-config branch from a5c38ba to 8580cf1 Compare August 20, 2021 17:51

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021

openshift-ci bot assigned jerolimov Aug 21, 2021

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 21, 2021

jerolimov approved these changes Aug 21, 2021

View reviewed changes

openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Aug 21, 2021

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 21, 2021

openshift-merge-robot merged commit 1db91c3 into openshift:master Aug 21, 2021

spadgett added this to the v4.9 milestone Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gherkin form based edit build config #9840

Gherkin form based edit build config #9840

sanketpathak commented Aug 19, 2021 •

edited

sanketpathak commented Aug 19, 2021

sanketpathak commented Aug 19, 2021

gajanan-more left a comment

jerolimov left a comment

jerolimov Aug 20, 2021 •

edited

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

jerolimov Aug 20, 2021

sanketpathak Aug 20, 2021

jerolimov commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

jerolimov commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

	Then user will see the Git Repository url, Image configuration, Environment Variables
	Then user will see the Name, Git repository url, Image configuration, Environment Variables

-             Then user will see the Git Repository url, Image configuration, Environment Variables
+             Then user will see the "Name" field
+              And user will see the "Git repo URL" field
+              And user will see the "Images" section
+              And user will see the "Environment Variables" section

		When user clicks on Show advanced options
		Then user will see the Triggers, Build Secret, Run Policy, Post-Commit Hooks

-             When user clicks on Show advanced options
-             Then user will see the Triggers, Build Secret, Run Policy, Post-Commit Hooks
+             When user clicks on Advanced option "Triggers"
+              And user clicks on Advanced option "Secrets"
+              And user clicks on Advanced option "Run Policy"
+              And user clicks on Advanced option "Hooks"
+             Then user will see section "Triggers"
+              And user will see section "Build Secret"
+              And user will see section "Run Policy"
+              And user will see section "Hooks"

	And user is at Edit Build Config page
	And user is at Edit Build Config page of deployment "flask-app-12"

		And user goes to Environment tab
		Then user will see Name as "<name>" and and Value as "<value>"

	resourceVersion: '1303043788'
	selfLink: /apis/build.openshift.io/v1/namespaces/aut-form-edit-build-config/buildconfigs/flask-app-12
	uid: e3927409-acab-11eb-8ed8-42010a8e0002

	uid: cd73cce1-75b4-484e-9b35-f6c9dc3ed8b6
	creationTimestamp: '2021-05-04T07:45:14Z'
	generation: 2

Gherkin form based edit build config #9840

Gherkin form based edit build config #9840

Conversation

sanketpathak commented Aug 19, 2021 • edited

sanketpathak commented Aug 19, 2021

sanketpathak commented Aug 19, 2021

gajanan-more left a comment

Choose a reason for hiding this comment

jerolimov left a comment

Choose a reason for hiding this comment

jerolimov Aug 20, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerolimov commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

jerolimov commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

openshift-bot commented Aug 21, 2021

sanketpathak commented Aug 19, 2021 •

edited

jerolimov Aug 20, 2021 •

edited