Bug 1996156: show a default sidebar for resources that doesn't have sidebar #9841

sahil143 · 2021-08-19T17:12:36Z

fixes: https://issues.redhat.com/browse/ODC-6261

Screenshot:

invincibleJai · 2021-08-20T10:18:03Z

/approve

look good needed to verify once.

rohitkrai03

@sahil143 Shouldn't the default resource details go into the details tab in the sidebar? The screenshot shows no tab in the sidebar.

sahil143 · 2021-08-20T10:42:27Z

@rohitkrai03 This was the default behavior for a resource that doesn't have a sidebar which got removed while working on the topology workload panel. ResourceOverviewPage handles this itself we don't send any information about the tab or anything.

rohitkrai03 · 2021-08-20T11:05:47Z

@sahil143 It feels odd to see it like that. I am okay if it was always like this but can we not put the resource overview into a details tab?

sahil143 · 2021-08-20T11:55:15Z

@rohitkrai03 fixed

rohitkrai03 · 2021-08-20T16:34:16Z

frontend/public/components/overview/resource-overview-page.tsx


 export const ResourceOverviewPage = connectToModel(({ kindObj, item, customActions }) => {
  if (!kindObj && !item?.obj) {
    return null;
  }
  const resourceModel = kindObj || modelFor(referenceFor(item.obj));
  const ref = referenceForModel(resourceModel);
-  const loader = resourceOverviewPages.get(ref, () => Promise.resolve(DefaultOverviewPage));
+  const loader = resourceOverviewPages.get(ref, () => Promise.resolve(DefaultSideBar));


Is this being used anywhere else apart from topology side bar? If yes do we want to change all of that? Or we should just add the tabs logic in topology sidebar only?

This is not being used anywhere apart from Topology

openshift-ci · 2021-08-20T17:22:07Z

@sahil143: This pull request references Bugzilla bug 1996156, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1996156: show a default sidebar for resources that doesn't have sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2021-08-20T17:23:13Z

/bugzilla refresh

openshift-ci · 2021-08-20T17:23:20Z

@sahil143: This pull request references Bugzilla bug 1996156, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rohitkrai03 · 2021-08-20T17:29:22Z

frontend/public/components/overview/resource-overview-page.tsx

+    <ResourceOverviewDetails
+      item={item}
+      kindObj={kindObj}
+      menuActions={customActions ? [...customActions, ...menuActions] : menuActions}


Do you need to check for customActions again here? Its already getting added in menuActions above.

rohitkrai03

/lgtm

openshift-ci · 2021-08-20T19:07:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [invincibleJai,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-08-20T19:55:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-20T20:08:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-20T23:59:08Z

@sahil143: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`c5cb01e`	link	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-21T00:54:43Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-21T00:56:31Z

@sahil143: All pull requests linked via external trackers have merged:

openshift/console#9841

Bugzilla bug 1996156 has been moved to the MODIFIED state.

In response to this:

Bug 1996156: show a default sidebar for resources that doesn't have sidebar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from christianvogt and debsmita1 August 19, 2021 17:17

openshift-ci bot added the component/topology Related to topology label Aug 19, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2021

rohitkrai03 suggested changes Aug 20, 2021

View reviewed changes

sahil143 force-pushed the bindable-sidepanel-fix branch from 0321e30 to ad85bf9 Compare August 20, 2021 11:54

openshift-ci bot added the component/core Related to console core functionality label Aug 20, 2021

rohitkrai03 suggested changes Aug 20, 2021

View reviewed changes

sahil143 changed the title ~~show a default sidebar for resources that doesn't have sidebar~~ Bug 1996156: show a default sidebar for resources that doesn't have sidebar Aug 20, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2021

rohitkrai03 suggested changes Aug 20, 2021

View reviewed changes

show a default sidebar for resources which doesn't have sidebar

c5cb01e

sahil143 force-pushed the bindable-sidepanel-fix branch from ad85bf9 to c5cb01e Compare August 20, 2021 17:39

rohitkrai03 approved these changes Aug 20, 2021

View reviewed changes

openshift-ci bot assigned rohitkrai03 Aug 20, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2021

openshift-merge-robot merged commit 3dc403e into openshift:master Aug 21, 2021

spadgett added this to the v4.9 milestone Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1996156: show a default sidebar for resources that doesn't have sidebar #9841

Bug 1996156: show a default sidebar for resources that doesn't have sidebar #9841

sahil143 commented Aug 19, 2021 •

edited

invincibleJai commented Aug 20, 2021

rohitkrai03 left a comment

sahil143 commented Aug 20, 2021

rohitkrai03 commented Aug 20, 2021

sahil143 commented Aug 20, 2021

rohitkrai03 Aug 20, 2021

sahil143 Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

sahil143 commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

rohitkrai03 Aug 20, 2021

rohitkrai03 left a comment

openshift-ci bot commented Aug 20, 2021

openshift-bot commented Aug 20, 2021

openshift-bot commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

openshift-bot commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

Bug 1996156: show a default sidebar for resources that doesn't have sidebar #9841

Bug 1996156: show a default sidebar for resources that doesn't have sidebar #9841

Conversation

sahil143 commented Aug 19, 2021 • edited

invincibleJai commented Aug 20, 2021

rohitkrai03 left a comment

Choose a reason for hiding this comment

sahil143 commented Aug 20, 2021

rohitkrai03 commented Aug 20, 2021

sahil143 commented Aug 20, 2021

rohitkrai03 Aug 20, 2021

Choose a reason for hiding this comment

sahil143 Aug 20, 2021

Choose a reason for hiding this comment

openshift-ci bot commented Aug 20, 2021

sahil143 commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

rohitkrai03 Aug 20, 2021

Choose a reason for hiding this comment

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Aug 20, 2021

openshift-bot commented Aug 20, 2021

openshift-bot commented Aug 20, 2021

openshift-ci bot commented Aug 20, 2021

openshift-bot commented Aug 21, 2021

openshift-ci bot commented Aug 21, 2021

sahil143 commented Aug 19, 2021 •

edited