Bug 1996539: show only route resource id sidepanel if route exists and show external url if status is present and has url

[invincibleJai]

Fixes:

https://issues.redhat.com/browse/ODC-6262

Screenshot / gif:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci]

@invincibleJai: This pull request references Bugzilla bug 1996539, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1996539: show only route resource id sidepanel if route exists and show external url if status is present and has url

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sahil143]

/lgtm

verified locally

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/knative-plugin/OWNERS [invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@invincibleJai: All pull requests linked via external trackers have merged:

• openshift/console#9849

Bugzilla bug 1996539 has been moved to the MODIFIED state.

In response to this:

Bug 1996539: show only route resource id sidepanel if route exists and show external url if status is present and has url

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[invincibleJai]

/cherry-pick release-4.8

[openshift-cherrypick-robot]

@invincibleJai: #9849 failed to apply on top of branch "release-4.8":

Applying: show only route resource id sidepanel if route existis and show external url if status is present and has url
Using index info to reconstruct a base tree...
M	frontend/packages/knative-plugin/src/components/overview/KSRoutesOverviewListItem.tsx
M	frontend/packages/knative-plugin/src/components/overview/__tests__/KSRoutesOverviewListItem.spec.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/knative-plugin/src/components/overview/__tests__/KSRoutesOverviewListItem.spec.tsx
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/components/overview/__tests__/KSRoutesOverviewListItem.spec.tsx
Auto-merging frontend/packages/knative-plugin/src/components/overview/KSRoutesOverviewListItem.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 show only route resource id sidepanel if route existis and show external url if status is present and has url
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.