Bug 1997108: fix react warnings while loading topology page #9866

sahil143 · 2021-08-24T12:32:08Z

fixes: https://issues.redhat.com/browse/ODC-6263

This PR fixes react warnings on the topology page with setQueryArguments and setState call.

openshift-ci · 2021-08-24T12:44:23Z

@sahil143: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1997108 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1997108: fix react warnings while loading topology page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

christianvogt · 2021-08-30T16:45:57Z

frontend/packages/topology/src/components/graph-view/Topology.tsx

-  if (!visualizationRef.current) {
-    visualizationRef.current = createVisualization();
-  }
  const visualization = visualizationRef.current;

+  React.useEffect(() => {
+    if (!visualizationRef.current) {
+      visualizationRef.current = createVisualization();
+    }
+  }, [createVisualization]);
+


Updating a ref in the render flow is ok. This doesn't require a change for it to be done inside an effect.

there is a setState call inside createVisualization, that's why moved the ref inside an effect.

I didn't realize that createVisualization was executing a callback which could set state. In that case what about:

if (!visualizationRef.current) { visualizationRef.current = createVisualization(); } const visualization = visualizationRef.current; React.useEffect(() => { if (visualization) { setVisualization(visualization); } }, [visualization]);

Then remove setVisualization from createVisualization.

Make sure to also fix-up TopologyListView which does something similar.

@christianvogt fixed

invincibleJai · 2021-08-31T08:50:40Z

/retest-required

invincibleJai · 2021-08-31T16:03:02Z

/approve

cc @christianvogt

christianvogt · 2021-09-02T14:03:05Z

frontend/packages/dev-console/src/plugin.tsx

-        '/topology/all-namespaces/graph',
-        '/topology/ns/:name/graph',
-        '/topology/all-namespaces/list',
-        '/topology/ns/:name/list',
+        '/topology/all-namespaces?view=graph',
+        '/topology/ns/:name?view=graph',
+        '/topology/all-namespaces?view=list',
+        '/topology/ns/:name?view=list',


I think you can remove these paths altogether since the query params don't matter here.

removed, only kept ones that are without the query params

Can I presume this change is OCP 4.9+ only?

Yes that's correct.

christianvogt · 2021-09-02T15:15:41Z

/lgtm

openshift-bot · 2021-09-02T16:54:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

sahil143 · 2021-09-02T16:58:18Z

@makambalaji The tests are failing on this PR as well for helm.

sahil143 · 2021-09-02T20:17:31Z

/bugzilla refresh

openshift-ci · 2021-09-02T20:17:35Z

@sahil143: This pull request references Bugzilla bug 1997108, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sahil143 · 2021-09-03T06:26:38Z

/retest

rohitkrai03

/lgtm

openshift-ci · 2021-09-03T09:51:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/dev-console/OWNERS~~ [christianvogt,invincibleJai,rohitkrai03]
~~frontend/packages/helm-plugin/OWNERS~~ [christianvogt,invincibleJai,rohitkrai03]
~~frontend/packages/topology/OWNERS~~ [christianvogt,invincibleJai,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-09-03T13:52:03Z

@sahil143: All pull requests linked via external trackers have merged:

openshift/console#9866

Bugzilla bug 1997108 has been moved to the MODIFIED state.

In response to this:

Bug 1997108: fix react warnings while loading topology page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from invincibleJai and karthikjeeyar August 24, 2021 12:32

openshift-ci bot added the component/topology Related to topology label Aug 24, 2021

sahil143 changed the title ~~fix react warnings while loading topology page~~ Bug 1997108: fix react warnings while loading topology page Aug 24, 2021

sahil143 force-pushed the odc-6263 branch 2 times, most recently from e4d2395 to 916e991 Compare August 30, 2021 06:11

christianvogt reviewed Aug 30, 2021

View reviewed changes

sahil143 force-pushed the odc-6263 branch from 916e991 to ea43972 Compare August 31, 2021 15:55

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021

sahil143 force-pushed the odc-6263 branch 3 times, most recently from 65baa4f to 21f2294 Compare September 2, 2021 10:52

openshift-ci bot added component/dev-console Related to dev-console component/helm Related to helm-plugin labels Sep 2, 2021

christianvogt reviewed Sep 2, 2021

View reviewed changes

sahil143 force-pushed the odc-6263 branch from 21f2294 to 885c335 Compare September 2, 2021 14:39

openshift-ci bot assigned christianvogt Sep 2, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021

openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 2, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 2, 2021

fix react warnings while loading topology page

27b8022

sahil143 force-pushed the odc-6263 branch from 885c335 to 27b8022 Compare September 3, 2021 09:12

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021

rohitkrai03 approved these changes Sep 3, 2021

View reviewed changes

openshift-ci bot assigned rohitkrai03 Sep 3, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021

openshift-merge-robot merged commit f4a7cb4 into openshift:master Sep 3, 2021

spadgett added this to the v4.9 milestone Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1997108: fix react warnings while loading topology page #9866

Bug 1997108: fix react warnings while loading topology page #9866

sahil143 commented Aug 24, 2021

openshift-ci bot commented Aug 24, 2021

christianvogt Aug 30, 2021

sahil143 Aug 31, 2021

christianvogt Aug 31, 2021 •

edited

christianvogt Aug 31, 2021

sahil143 Sep 1, 2021

invincibleJai commented Aug 31, 2021

invincibleJai commented Aug 31, 2021

christianvogt Sep 2, 2021

sahil143 Sep 2, 2021

cardil Sep 7, 2021

christianvogt Sep 14, 2021

christianvogt commented Sep 2, 2021

openshift-bot commented Sep 2, 2021

sahil143 commented Sep 2, 2021

sahil143 commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

sahil143 commented Sep 3, 2021

rohitkrai03 left a comment

openshift-ci bot commented Sep 3, 2021

openshift-ci bot commented Sep 3, 2021

Bug 1997108: fix react warnings while loading topology page #9866

Bug 1997108: fix react warnings while loading topology page #9866

Conversation

sahil143 commented Aug 24, 2021

openshift-ci bot commented Aug 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianvogt Aug 31, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

invincibleJai commented Aug 31, 2021

invincibleJai commented Aug 31, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianvogt commented Sep 2, 2021

openshift-bot commented Sep 2, 2021

sahil143 commented Sep 2, 2021

sahil143 commented Sep 2, 2021

openshift-ci bot commented Sep 2, 2021

sahil143 commented Sep 3, 2021

rohitkrai03 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Sep 3, 2021

openshift-ci bot commented Sep 3, 2021

christianvogt Aug 31, 2021 •

edited