Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1996630: Fix some issues while updating ssh keys from simple wizard and changing keys #9881

Conversation

metalice
Copy link
Contributor

@metalice metalice commented Aug 25, 2021

Signed-off-by: Matan Schatzman mschatzm@redhat.com
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1996630
https://bugzilla.redhat.com/show_bug.cgi?id=1996622

Screen shots / Gifs for design review:
ssh-fixed

…g keys

Signed-off-by: Matan Schatzman <mschatzm@redhat.com>
@metalice metalice changed the title Fix some issues while updaing ssh keys from simple wizard and changing keys Bug 1996630: Fix some issues while updating ssh keys from simple wizard and changing keys Aug 25, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 25, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2021

@metalice: This pull request references Bugzilla bug 1996630, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1996630: Fix some issues while updating ssh keys from simple wizard and changing keys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added component/kubevirt Related to kubevirt-plugin bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2021
@openshift-ci openshift-ci bot requested a review from gouyang August 25, 2021 11:17
@metalice
Copy link
Contributor Author

/test e2e-gcp-console

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@metalice: This pull request references Bugzilla bug 1996630, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1996630: Fix some issues while updating ssh keys from simple wizard and changing keys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pcbailey
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 8aa7f76 into openshift:master Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1996630 has been moved to the MODIFIED state.

In response to this:

Bug 1996630: Fix some issues while updating ssh keys from simple wizard and changing keys

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants