Bug 1997655: Remove unused data-test-id which logs a react warning #9883
Conversation
|
@jerolimov: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1997655 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
bot
requested review from
karthikjeeyar,
debsmita1 and
invincibleJai
|
@jerolimov: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1997655 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
component/pipelines
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerolimov, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jerolimov: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1997655 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@jerolimov: An error was encountered querying GitHub for users with public email (gamore@redhat.com) for bug 1997655 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-low
|
@jerolimov: This pull request references Bugzilla bug 1997655, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-gcp-console |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jerolimov: All pull requests linked via external trackers have merged: Bugzilla bug 1997655 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1997655
Analysis / Root cause:
When open the pipelines it shows a React warning/error in the browser console:
Solution Description:
Just remove the Fragment /
data-test-idbecause it look nobody uses it (wasn't rendered before). The changed was introduced with #9797Screen shots / Gifs for design review:
Dom rendering looks still good (tr exists):
Unit test coverage report:
Not touched
Test setup:
Browser conformance: