Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin for export of application in topology #9887

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Aug 26, 2021

Epic: https://issues.redhat.com/browse/ODC-2148
Story: https://issues.redhat.com/browse/ODC-6280

Acceptance criteria:

  • Users can access an Export CTA from Topology to export resources in the selected namespace. Note that users will not be able to pick and choose which resources will be exported.

Checks required for approving Epic gherkin scripts PR:

  • Add @epic-number to the scenarios or feature file [e.g: @odc-xxx]
  • Add @to-do for automation possible scenarios
  • Add @regression or @smoke based on the importance of the scenario
  • Update the test scenarios count in Automation status confluence Report
  • Check for the linter issues by executing yarn run gherkin-lint on frontend folder [Skip epic number tags related linter issues]

@openshift-ci openshift-ci bot added the component/topology Related to topology label Aug 26, 2021
And user has created a deployment workload
When user goes to Topology
And user clicks on Export Application button
Then user can see Export Application modal saying "Export of resources in aut-export-application has started."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'll be a toast message

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Scenario: Export Application is created: KC-02-TC02
Given user is at Topology
And Export Application is completed
And user clicks on download button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user will be shown with a toast message on export completion along with a link to download

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right And user clicks on download button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sanketpathak sanketpathak force-pushed the gherkin-export-application branch 2 times, most recently from ad9ab39 to 68d5407 Compare August 27, 2021 12:48
@makambalaji
Copy link
Contributor

/assign @makambalaji

Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "export-application" folder in Topology plugin folder?

Comment on lines 9 to 11
Given user has installed Gitops primer Operator
And user has created or selected namespace "aut-export-application"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user has installed Gitops primer Operator
And user has created or selected namespace "aut-export-application"
Given user has installed Gitops primer Operator
And user is at developer perspective
And user has created or selected namespace "aut-export-application"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


@smoke @to-do
Scenario: Export application button in topology: EA-02-TC01
Given user is at Developer perspective
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to BackGround section and remove it from here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@smoke @to-do
Scenario: Export application button in topology: EA-02-TC01
Given user is at Developer perspective
And user has created a deployment workload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide the test data ""

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Scenario: Export application button in topology: EA-02-TC01
Given user is at Developer perspective
And user has created a deployment workload
When user goes to Topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When user goes to Topology
When user navigates to Topology

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


@regression @to-do
Scenario: Export Application modal when export application is in progress: EA-02-TC02
Given user is at Topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user is at Topology
Given user is at Topology page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


@regression @to-do
Scenario: Export application button in empty topology view: EA-02-TC03
Given user is at Developer perspective
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line and move it to BackGround section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Scenario: Export application button in empty topology view: EA-02-TC03
Given user is at Developer perspective
And user has created or selected namespace "aut-export-applicatio-temp"
When user goes to Topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When user goes to Topology
When user navigates to Topology page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


@regression @manual
Scenario: Export Application is created: EA-02-TC04
Given user is at Topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user is at Topology
Given user is at Topology page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Given user is at Topology
And Export Application is completed
Then user can see a toast message on export completion along with a link to download
And user can see a deployment workload for primer is created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Given condition,
'User created deployment workload "<>"' is required and share that workload name here in this step for more clarity

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a workload when the primer Job is finished the primer deployment is created


@regression @manual
Scenario: Download the exported application: EA-02-TC05
Given user is at Topology
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Given user is at Topology
Given user is at Topology page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@sanketpathak
Copy link
Contributor Author

Yes, as the feature code is present in the Topology plugin so we need the export application tests in Topology at this moment

@invincibleJai
Copy link
Member

/approve

cc @makambalaji

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@makambalaji
Copy link
Contributor

/lgtm

@makambalaji
Copy link
Contributor

/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR lgtm Indicates that a PR is ready to be merged. labels Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b9c5b6a into openshift:master Aug 31, 2021
@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants