Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1998364: Use the central i18n mocks for all tests and add support for variables #9901

Merged
merged 1 commit into from Aug 27, 2021
Merged

Bug 1998364: Use the central i18n mocks for all tests and add support for variables #9901

merged 1 commit into from Aug 27, 2021

Conversation

jerolimov
Copy link
Member

@jerolimov jerolimov commented Aug 26, 2021 •
edited

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1998364

Analysis / Root cause:
Mocking react-i18next was required in many tests and was inconsistent implemented per test.

Solution Description:
Remove react-i18next from individual tests and extend the existing central implementation with variable support.

Update tests so that they doesn't expect any package prefix (public~ etc.) anymore and that the expected strings contains real variable values.

Screen shots / Gifs for design review:
Nothing changed on the UI.

Unit test coverage report:
Should not be affected.

Test setup:
yarn test

Browser conformance:
Not relevant

@openshift-ci openshift-ci bot added component/ceph Related to ceph-storage-plugin component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2021
@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Aug 26, 2021
@jerolimov jerolimov force-pushed the cleanup-react-i18n-mock branch 2 times, most recently from 4f30a9b to 53af4f0 Compare August 26, 2021 18:45
spadgett
spadgett reviewed Aug 26, 2021
View reviewed changes
frontend/packages/console-dynamic-plugin-sdk/src/utils/fetch/console-fetch-utils.ts Outdated
const { kind, name } = InternalReduxStore.getState().UI.get('impersonate', {});
let kind: string;
let name: string;
try {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bad rebase.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A wip fix for another unit test issue. Always good to have someone looking closely.

Rebased and removed this change.

frontend/__tests__/components/storage-class-form.spec.tsx Show resolved Hide resolved
@spadgett
Copy link
Member

/retest

spadgett
spadgett approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jerolimov jerolimov changed the title Use the central i18n mocks for all tests and add support for variables Bug 1998364: Use the central i18n mocks for all tests and add support for variables Aug 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2021

@jerolimov: This pull request references Bugzilla bug 1998364, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1998364: Use the central i18n mocks for all tests and add support for variables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 26, 2021
@openshift-merge-robot openshift-merge-robot merged commit 0692e18 into openshift:master Aug 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

@jerolimov: All pull requests linked via external trackers have merged:

Bugzilla bug 1998364 has been moved to the MODIFIED state.

In response to this:

Bug 1998364: Use the central i18n mocks for all tests and add support for variables

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

@afreen23 afreen23 Awaiting requested review from afreen23

Assignees

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerolimov @spadgett @openshift-merge-robot