Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1998394: add tests for RHEL9 template #9905

Merged
merged 1 commit into from Sep 1, 2021
Merged

Bug 1998394: add tests for RHEL9 template #9905

merged 1 commit into from Sep 1, 2021

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Aug 27, 2021 •
edited

review notes:

  1. upstream has no RHEL9 template, move the test downstream only
  2. there is a test failure on action/clone.spec.ts, try to fix the flaky here.
  3. add a new constant TEMPLATE.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

@gouyang: This pull request references Bugzilla bug 1998394, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1998394: add tests for RHEL9 template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 1998394, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1998394: add tests for RHEL9 template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the component/kubevirt Related to kubevirt-plugin label Aug 27, 2021
@gouyang
Copy link
Contributor Author

gouyang commented Aug 27, 2021 •
edited

@yaacov does the CI has RHEL9 template? some test are failed because of it.
Expected to find content: 'Red Hat Enterprise Linux 9.0 Alpha VM' within the element: [ <div.catalog-tile-pf-title>, 12 more... ] but never did.

Answer by myself: upstream has no RHEL9 template yet. Move the test downstream only.

@gouyang gouyang force-pushed the rhel9_template branch 2 times, most recently from 3968d24 to 2a6261c Compare August 27, 2021 12:06
@gouyang
Copy link
Contributor Author

gouyang commented Aug 28, 2021

/retest

@gouyang gouyang force-pushed the rhel9_template branch 4 times, most recently from 9671617 to c439917 Compare August 31, 2021 01:59
@gouyang
Copy link
Contributor Author

gouyang commented Aug 31, 2021

/retest

@gouyang gouyang force-pushed the rhel9_template branch 2 times, most recently from 762e11c to 5c89172 Compare August 31, 2021 12:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@gouyang: This pull request references Bugzilla bug 1998394, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1998394: add tests for RHEL9 template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: gouyang.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@gouyang: This pull request references Bugzilla bug 1998394, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @gouyang

In response to this:

Bug 1998394: add tests for RHEL9 template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gouyang
Copy link
Contributor Author

gouyang commented Aug 31, 2021

@yaacov @pcbailey PTAL.

pcbailey
pcbailey reviewed Sep 1, 2021
View reviewed changes
Copy link
Contributor

@pcbailey pcbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

frontend/packages/kubevirt-plugin/integration-tests-cypress/utils/const/index.ts
win2k12 = 'Microsoft Windows Server 2012 R2',
rhel8 = 'Red Hat Enterprise Linux 8.0 or higher',
}
export const TEMPLATE = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so nice! =)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 598b151 into openshift:master Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 1998394 has been moved to the MODIFIED state.

In response to this:

Bug 1998394: add tests for RHEL9 template

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.9 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcbailey pcbailey pcbailey left review comments

@jelkosz jelkosz Awaiting requested review from jelkosz

Assignees

@pcbailey pcbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gouyang @pcbailey @spadgett @openshift-merge-robot