Bug 1998575: Fix that insert yaml does nothing when yaml is provided via an extension (also hide samples when user edits a resource)

[jerolimov]

Fixes:
https://issues.redhat.com/browse/ODC-6301
https://bugzilla.redhat.com/show_bug.cgi?id=1998575

Analysis / Root cause:
When the user presses on insert it doesn't insert any YAML because the YAML templates was provided by an extension.

It also shows an error just in development mode because the YAML was undefined.

It was also incorrect that the YAML (field) editor shows the samples at all. At least our generic YAML editor shows samples only if the user creates a new resource.

Solution Description:

1. Adds some defaults and types to ensure that the YAML is at least an empty string when editor.setValue is called. This fixes the error which was only shown in development mode. (With this change alone we still have a button which do nothing.)
2. Loads the YAMLTemplate extensions YAMLEditorField.tsx to load the right YAML. (With this change we have now a button which inserts a YAML (template) sample in the editor.)
3. Only shows the samples in YAMLEditorField.tsx similar to edit-yaml.jsx only if the user creates a new resource. Added a new prop showSamples for this to make the decision in the parent component.
   1. In BuildConfigForm, EditDeploymentForm, HPAForm and PipelineBuilderForm only when editoring a resource (a resource is loaded successfully)
   2. In HelmInstallUpgradeForm never (the helm itself is the "sample", right?)
   3. In knative add/EventSourceForm, add/brokers/AddBrokerForm and add/channels/form-fields/ChannelYamlEditor always because these forms are obviously add only forms

Screen shots / Gifs for design review:
BuildConfig before:

BuildConfig after (no samples anymore):

Create Pipeline with Pipeline Builder before:

Create Pipeline with Pipeline Builder after (same as expected):

Edit Pipeline with Pipeline Builder before:

Edit Pipeline with Pipeline Builder after (no samples anymore):

Unit test coverage report:
Unchanged

Test setup:
Unchanged

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[jerolimov]

/kind bug
/cc @debsmita1 @rohitkrai03

[openshift-ci]

@jerolimov: This pull request references Bugzilla bug 1998575, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

Bug 1998575: Fix that insert yaml does nothing when yaml template provides data via an extension (also hide samples when user edits a resource)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/test e2e-gcp-console

[jerolimov]

/retest

[jerolimov]

/retest

[rohitkrai03]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [jerolimov,rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#9909

Bugzilla bug 1998575 has been moved to the MODIFIED state.

In response to this:

Bug 1998575: Fix that insert yaml does nothing when yaml is provided via an extension (also hide samples when user edits a resource)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.