Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1999614: Add name field in edit deployment form #9911

Merged
merged 1 commit into from Sep 1, 2021

Conversation

divyanshiGupta
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-6228

Screenshot:
Screenshot 2021-08-27 at 10 05 21 PM

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2021
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Aug 27, 2021
Copy link
Contributor

@sahil143 sahil143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

verified locally. Can see the disabled input field on Edit Deployment and DC form

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2021
@divyanshiGupta divyanshiGupta changed the title Add name field in edit deployment form Bug 1999614: Add name field in edit deployment form Aug 31, 2021
@divyanshiGupta
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@divyanshiGupta: This pull request references Bugzilla bug 1999614, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@divyanshiGupta: This pull request references Bugzilla bug 1999614, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1999614: Add name field in edit deployment form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rohitkrai03
Copy link
Contributor

/retest

Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3a74f2c into openshift:master Sep 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2021

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1999614 has been moved to the MODIFIED state.

In response to this:

Bug 1999614: Add name field in edit deployment form

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

/cherrypick release-4.8

@openshift-cherrypick-robot

@divyanshiGupta: #9911 failed to apply on top of branch "release-4.8":

Applying: Add name field in edit deployment form
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add name field in edit deployment form
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@divyanshiGupta: #9911 failed to apply on top of branch "release-4.8":

Applying: Add name field in edit deployment form
Using index info to reconstruct a base tree...
M	frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
CONFLICT (content): Merge conflict in frontend/packages/dev-console/src/components/edit-deployment/EditDeploymentFormEditor.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add name field in edit deployment form
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants