Bug 1998408: Avoid resetting dockerfile path when switching build strategies

[rottencandy]

Fixes:
https://issues.redhat.com/browse/ODC-6289

Analysis / Root cause:
Dockerfile path gets reset to Dockerfile when switching from devfile build strategy.

Solution Description:
Avoid resetting dockerfile path when switching.

Screen shots / Gifs for design review:

0.mp4

Unit test coverage report:
(Unchanged)

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug

[openshift-ci]

@rottencandy: This pull request references Bugzilla bug 1998408, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1998408: Avoid resetting dockerfile path when switching build strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sahil143]

/lgtm

[rottencandy]

/bugzilla refresh

[openshift-ci]

@rottencandy: This pull request references Bugzilla bug 1998408, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (gamore@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

Only concern I have with this is the Dockerfile field is not always visible... but it appears it is used sometimes it's not visible. DockerfilePath is used in Devfile. But not visible due to the initial support we had.

I think this is fine though, might cause some unexpected results but it would require someone to go out of their way to do it.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, rottencandy, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rottencandy: All pull requests linked via external trackers have merged:

• openshift/console#9895
• openshift/console#9917

Bugzilla bug 1998408 has been moved to the MODIFIED state.

In response to this:

Bug 1998408: Avoid resetting dockerfile path when switching build strategies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.